Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add introspection to ROS release for master branch #2101

Conversation

mossmaurice
Copy link
Contributor

@mossmaurice mossmaurice commented Nov 17, 2023

Pre-Review Checklist for the PR Author

  1. Add a second reviewer for complex new features or larger refactorings
  2. Code follows the coding style of CONTRIBUTING.md
  3. Tests follow the best practice for testing
  4. Changelog updated in the unreleased section including API breaking changes
  5. Branch follows the naming format (iox-123-this-is-a-branch)
  6. Commits messages are according to this guideline
  7. Update the PR title
    • Follow the same conventions as for commit messages
    • Link to the relevant issue
  8. Relevant issues are linked
  9. Add sensible notes for the reviewer
  10. All checks have passed (except task-list-completed)
  11. All touched (C/C++) source code files from iceoryx_hoofs are added to ./clang-tidy-diff-scans.txt
  12. Assign PR to reviewer

Notes for Reviewer

  • Add introspection to ROS release

Checklist for the PR Reviewer

  • Commits are properly organized and messages are according to the guideline
  • Code according to our coding style and naming conventions
  • Unit tests have been written for new behavior
  • Public API changes are documented via doxygen
  • Copyright owner are updated in the changed files
  • All touched (C/C++) source code files from iceoryx_hoofs have been added to ./clang-tidy-diff-scans.txt
  • PR title describes the changes

Post-review Checklist for the PR Author

  1. All open points are addressed and tracked via issues

References

@mossmaurice mossmaurice added the tooling All iceoryx related tooling (scripts etc.) label Nov 17, 2023
@mossmaurice mossmaurice self-assigned this Nov 17, 2023
@mossmaurice mossmaurice force-pushed the iox-2099-add-introspection-to-ros-release-master-branch branch 3 times, most recently from 75283be to e744690 Compare November 17, 2023 14:03
@mossmaurice mossmaurice requested a review from dkroenke November 17, 2023 14:05
@mossmaurice mossmaurice marked this pull request as ready for review November 17, 2023 14:06
Copy link
Member

@elBoberido elBoberido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Just one clarification regarding the support e-mail

elBoberido
elBoberido previously approved these changes Nov 20, 2023
@mossmaurice mossmaurice force-pushed the iox-2099-add-introspection-to-ros-release-master-branch branch from e744690 to 0d63522 Compare November 20, 2023 21:16
elBoberido
elBoberido previously approved these changes Nov 20, 2023
@mossmaurice mossmaurice force-pushed the iox-2099-add-introspection-to-ros-release-master-branch branch from 0d63522 to fc6420e Compare November 22, 2023 08:39
@mossmaurice
Copy link
Contributor Author

@elBoberido Could you re-approve? I fixed one dependency.

@mossmaurice mossmaurice requested review from elBoberido and removed request for dkroenke November 22, 2023 08:39
Copy link

codecov bot commented Nov 22, 2023

Codecov Report

Merging #2101 (fc6420e) into master (b40502d) will increase coverage by 0.01%.
Report is 1 commits behind head on master.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2101      +/-   ##
==========================================
+ Coverage   80.29%   80.30%   +0.01%     
==========================================
  Files         417      417              
  Lines       16132    16132              
  Branches     2253     2253              
==========================================
+ Hits        12953    12955       +2     
+ Misses       2384     2383       -1     
+ Partials      795      794       -1     
Flag Coverage Δ
unittests 80.09% <ø> (+0.01%) ⬆️
unittests_timing 15.29% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

@mossmaurice mossmaurice merged commit c07fa9f into eclipse-iceoryx:master Nov 22, 2023
@mossmaurice mossmaurice deleted the iox-2099-add-introspection-to-ros-release-master-branch branch November 22, 2023 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tooling All iceoryx related tooling (scripts etc.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants