Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure out-of-date messages have warning severity #815

Merged
merged 1 commit into from
Oct 2, 2018
Merged

Ensure out-of-date messages have warning severity #815

merged 1 commit into from
Oct 2, 2018

Conversation

fbricon
Copy link
Contributor

@fbricon fbricon commented Oct 1, 2018

Fixes #813

@fbricon fbricon requested a review from snjeza October 1, 2018 23:02
@fbricon
Copy link
Contributor Author

fbricon commented Oct 1, 2018

My understanding of the bug is jdt.ls did set the warning severity 1st and then the m2e plugin initialized its preferences, which reset the default value to error.
Setting the preference via InstanceScope.INSTANCE instead of DefaultScope.INSTANCE seems to do the trick.

@fbricon fbricon merged commit 71990e8 into eclipse-jdtls:master Oct 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@snjeza snjeza snjeza approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fbricon @snjeza