Skip to content

Commit

Permalink
fix #3838: upgrade xterm to fix terminal dragging between areas
Browse files Browse the repository at this point in the history
Signed-off-by: Anton Kosyakov <[email protected]>
  • Loading branch information
akosyakov committed May 15, 2019
1 parent 2f90ca0 commit 9e53000
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 5 deletions.
2 changes: 1 addition & 1 deletion packages/terminal/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
"@theia/filesystem": "^0.6.0",
"@theia/process": "^0.6.0",
"@theia/workspace": "^0.6.0",
"xterm": "3.9.2"
"xterm": "3.13.0"
},
"publishConfig": {
"access": "public"
Expand Down
5 changes: 5 additions & 0 deletions packages/terminal/src/browser/terminal-widget-impl.ts
Original file line number Diff line number Diff line change
Expand Up @@ -288,18 +288,23 @@ export class TerminalWidgetImpl extends TerminalWidget implements StatefulWidget
}
}
protected onFitRequest(msg: Message): void {
super.onFitRequest(msg);
MessageLoop.sendMessage(this, Widget.ResizeMessage.UnknownSize);
}
protected onActivateRequest(msg: Message): void {
super.onActivateRequest(msg);
this.term.focus();
}
protected onAfterShow(msg: Message): void {
super.onAfterShow(msg);
this.update();
}
protected onAfterAttach(msg: Message): void {
super.onAfterAttach(msg);
this.update();
}
protected onResize(msg: Widget.ResizeMessage): void {
super.onResize(msg);
this.needsResize = true;
this.update();
}
Expand Down
8 changes: 4 additions & 4 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -10441,10 +10441,10 @@ xtend@~2.1.1:
dependencies:
object-keys "~0.4.0"

xterm@3.9.2:
version "3.9.2"
resolved "https://registry.yarnpkg.com/xterm/-/xterm-3.9.2.tgz#e94bfbb84217b19bc1c16ed43d303b8245c9313d"
integrity sha512-fpQJQFTosY97EK4eB7UOrlFAwwqv1rSqlXgttEVD0S1v4MlevsUkRwrM/ew5X73jQXc+vdglRtccIhcXg5wtGg==
xterm@3.13.0:
version "3.13.0"
resolved "https://registry.yarnpkg.com/xterm/-/xterm-3.13.0.tgz#d0e06c3cf4c1f079aa83f646948457db3b04220b"
integrity sha512-FZVmvkkbkky3zldJ2NNOZ9h8jirtbGTlF4sIKMDrejR4wPsVZ3o4F++DQVkdeZqjAwtNOMoR17PMSOTZ+h070g==

y18n@^3.2.1:
version "3.2.1"
Expand Down

0 comments on commit 9e53000

Please sign in to comment.