Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[terminal] Not useable after dragging into a different tab folder #3838

Closed
AlexTugarev opened this issue Dec 14, 2018 · 5 comments · Fixed by #4680
Closed

[terminal] Not useable after dragging into a different tab folder #3838

AlexTugarev opened this issue Dec 14, 2018 · 5 comments · Fixed by #4680
Assignees
Labels
bug bugs found in the application terminal issues related to the terminal

Comments

@AlexTugarev
Copy link
Contributor

It seems the terminal sometimes doesn't draw any updates after dragging into a different tab folder.

2018-12-14 13 55 45

@AlexTugarev AlexTugarev added bug bugs found in the application terminal issues related to the terminal labels Dec 14, 2018
@akosyakov
Copy link
Member

@AlexTugarev after merging latest xterm?

@AlexTugarev
Copy link
Contributor Author

@akosyakov, nope. that issues existed before, demoed state of commit fed4e73

@pdrd
Copy link

pdrd commented Feb 12, 2019

We are experiencing the same behaviour. No customizations, only a package.json with several @theia-plugins all with 'latest' version and default build config. No log output. Browser is latest Google Chrome.
It's also reproducible on gitpod.io, when you drag around a terminal.

Any clues how to address this issue? It looks like a missing redraw call to the widget, because after a page reload the terminal content reappears, but my knowledge about the widget/plugin system is not sufficient to find the buggy code section.

@lmcbout
Copy link
Contributor

lmcbout commented Mar 21, 2019

This issue still exist with Theia 0.4.0. Until I restart the client, the terminal is not usable and does not display the data already typed in the terminal.

@akosyakov
Copy link
Member

It's a bug in xterm: xtermjs/xterm.js@69d3a46

It was fixed in 3.12.0. We need to upgrade xterm to pick it up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug bugs found in the application terminal issues related to the terminal
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants