Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply breakpoints on startup #2996

Merged
merged 1 commit into from
Oct 1, 2018
Merged

Apply breakpoints on startup #2996

merged 1 commit into from
Oct 1, 2018

Conversation

tolusha
Copy link
Contributor

@tolusha tolusha commented Sep 27, 2018

Signed-off-by: Anatoliy Bazko [email protected]

What does this PR do:

  • wait initialize event before setting breakpoints
  • fix breakpoints appearance in the editor when debugger is connected
  • small changes

Reference issue

#2978

@tolusha tolusha added the debug issues that related to debug functionality label Sep 27, 2018
@tolusha tolusha self-assigned this Sep 27, 2018
@tolusha tolusha requested a review from akosyakov September 27, 2018 14:35
@tolusha
Copy link
Contributor Author

tolusha commented Sep 28, 2018

Configuration to debug mocha tests work perfectly on my side.
@akosyakov Could you check if PR solves the issue?

@tolusha tolusha added the bug bugs found in the application label Sep 28, 2018
@tsmaeder tsmaeder mentioned this pull request Sep 28, 2018
Closed
19 tasks
akosyakov
akosyakov approved these changes Oct 1, 2018
View reviewed changes
Copy link
Member

@akosyakov akosyakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good, thanks.

packages/debug/src/browser/debug-session.ts Show resolved Hide resolved
@tolusha
Apply breakpoints on startup
89d1024 
Signed-off-by: Anatoliy Bazko <[email protected]>
@tolusha tolusha force-pushed the ab/applyBreakpoints branch from a7fb6de to 89d1024 Compare October 1, 2018 09:52
@tolusha tolusha merged commit eb58090 into master Oct 1, 2018
@tolusha tolusha deleted the ab/applyBreakpoints branch October 1, 2018 11:02
@tsmaeder tsmaeder mentioned this pull request Oct 2, 2018
Closed
15 tasks
@tsmaeder tsmaeder mentioned this pull request Oct 25, 2018
Closed
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akosyakov akosyakov akosyakov approved these changes

Assignees

@tolusha tolusha

Labels
bug bugs found in the application debug issues that related to debug functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tolusha @akosyakov