Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #6996 TOGGLE_MAXIMIZED overrides monaco tab capture #7012

Conversation

caseyflynn-google
Copy link
Contributor

What it does

Change modifies the default TOGGLE_MAXIMIZED keybinding from ctrl+m to
alt+m to ensure it does not overwrite a11y feature of Monaco "toggle tab
key moves focus".

How to test

  1. Open Theia
  2. Open a file for edit
  3. Issue Ctrl+m

Observe pressing the tab key changes focus as opposed to sending a tab to the editor.

  1. Focus the editor
  2. Issue alt+m

Observe toggle maximize works as intended.

Review checklist

Reminder for reviewers

Change modifies the default TOGGLE_MAXIMIZED keybinding from ctrl+m to
alt+m to ensure it does not overwrite a11y feature of Monaco "toggle tab
key moves focus".

Signed-off-by: Casey Flynn <[email protected]>
@caseyflynn-google caseyflynn-google added keybindings issues related to keybindings accessibility issues related to accessbilitiy labels Jan 29, 2020
@akosyakov
Copy link
Member

alt+m does not work for the focused terminal (tab highlighted with blueish bar) for me on ubuntu.It is the main use case to zoom in/out terminals.

@eclipse-theia/ecd-theia-committers Which shortcut could be better?

@marcdumais-work
Copy link
Contributor

alt+m does not work for the focused terminal (tab highlighted with blueish bar) for me on ubuntu.It is the main use case to zoom in/out terminals.

Same for me on my Ubuntu 18.04-based laptop. However ctrl-m behaves the same for me on master, so not a new problem it seems.

Copy link
Member

@akosyakov akosyakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's try this keybinding

@caseyflynn-google caseyflynn-google merged commit 86704a9 into eclipse-theia:master Jan 31, 2020
@caseyflynn-google caseyflynn-google deleted the change_maximize_keybinding branch January 31, 2020 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility issues related to accessbilitiy keybindings issues related to keybindings
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants