core: call every contribution on unload

[paul-marechal]

The current procedure bails early on the first contribution that
prevents unloading. This means that other contributions are not
notified.

This commit makes sure that all contributions are called.

Signed-off-by: Paul Maréchal [email protected]

How to test

Review checklist

• as an author, I have thoroughly tested my changes and carefully followed the review guidelines

Reminder for reviewers

• as a reviewer, I agree to behave in accordance with the review guidelines

[kittaakos]

How to test

How to test it?

[colin-grant-work]

I thought your explanation in the other PR about onWillStop not being for cleanup code was good enough for me. Maybe we should just update the javadoc here to emphasize that onStop should perform cleanup and onWillStop is only for preventing the stop:

theia/packages/core/src/browser/frontend-application.ts

Lines 51 to 65 in 9e950a8

	/**
	* Called on `beforeunload` event, right before the window closes.
	* Return `true` in order to prevent exit.
	* Note: No async code allowed, this function has to run on one tick.
	*/
	onWillStop?(app: FrontendApplication): boolean | void;
	/**
	* Called when an application is stopped or unloaded.
	*
	* Note that this is implemented using `window.beforeunload` which doesn't allow any asynchronous code anymore.
	* I.e. this is the last tick.
	*/
	onStop?(app: FrontendApplication): void;

[paul-marechal]

@kittaakos I added a unit test, thanks for reminding me!

[paul-marechal]

@colin-grant-work Right, we can either call everyone or not, but it seems to make more sense to call everyone. At least it would be a fair expectation from something called onWillStop.