fix(BpdmService): cx-memberships call to expect custom api path #1300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is a customizable poolApiPath in portal values including API version. Calls are failing if the pool has any path. Refs: eclipse-tractusx#1299
typecastcloud
commented
Feb 26, 2025
|
tfjanjua
suggested changes
Feb 27, 2025
typecastcloud
requested review from
ntruchsess,
Phil91,
evegufy and
tfjanjua
|
Successfully tested from local. Please review. |
tfjanjua
approved these changes
Feb 27, 2025
There was a problem hiding this comment.
@typecastcloud
I have tested your changes on my local and its working fine
I tried with 2 BPNs
BPNL000000000065
BPNL00000000015G
and received success response from the pool/v6/cx-memberships API
2 tasks
ntruchsess
approved these changes
Feb 27, 2025
typecastcloud
merged commit 0430fdf
into
eclipse-tractusx:release/v2.4.0-RC2
11 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove hardcoded v6 path in bpdm cx-memberships api call. BusinessPartnerPoolBaseAddress should contain base api path including version.
Why
There is a customizable poolApiPath in portal values including API version. Calls are failing if the pool has any path.
Issue
Refs: #1299
Depends on: eclipse-tractusx/portal#518
Checklist