fix(registration): bpdm pool address for membership activation #518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hardcoded path in portal backend does not follow intended behavior. Refs: eclipse-tractusx/portal-backend#1299
tfjanjua
suggested changes
Feb 26, 2025
Phil91
approved these changes
Feb 27, 2025
evegufy
approved these changes
Feb 27, 2025
tfjanjua
approved these changes
Feb 27, 2025
There was a problem hiding this comment.
I see the required backend change has also been done eclipse-tractusx/portal-backend#1300
@typecastcloud
I have tested your changes on my local and its working fine
I tried with 2 BPNs
BPNL000000000065
BPNL00000000015G
and received success response from the pool/v6/cx-memberships API
ntruchsess
approved these changes
Feb 27, 2025
typecastcloud
deleted the
fix/bpdm-pool-address-for-membership-activation
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use configurable poolApiPath in BPDM pool address for application activation.
Why
Hardcoded path in portal backend does not follow intended behavior if Pool address is using any additional pathing other than v6.
Issue
Refs: eclipse-tractusx/portal-backend#1299
Checklist