Parse nested tags with equal name (solves #3) #8

myrho · 2017-06-01T12:36:25Z

Code and tests to allow parsing of <tag><tag></tag></tag> strings.
Looks ahead for open and close tags, puts 'em in a list and then reduces consecutive pairs in the list to elements.

…ore '/>'. Add '<there/>' example to the test suite. Update the tests for version 4.2 to 5 of elm-test. No more Main.elm. Remove elm-doc-test installation and use. There aren't any doc tests, and it was generating files that didn't compile on my machine.

billstclair · 2017-12-05T01:20:37Z

I made a pull request on myrho's fork which fixes one small bug and also updates the tests for the latest version of elm-test, fixing the problem that makes this pull request fail.

But myrho has not replied. I could package up both his and my changes as a pull request here, if you'd like.

You may also be interested in billstclair/elm-xml-extra, which makes it easy to write JSON Decoders for simple XML (ignoring the attributes).

Parse a self-closing tag with no attributes and no space before '/>'

billstclair · 2017-12-05T10:14:09Z

The test failure is a Travis problem. The macOS build worked. Restart the Linux build, and it should also work.

eeue56 · 2017-12-05T12:13:45Z

.travis.yml

@@ -24,7 +24,6 @@ install:
  - npm --version
  - npm install -g elm@$ELM_VERSION
  - npm install -g elm-test
-  - npm install -g elm-doc-test


why was this removed? 🤔

It wasn't working for me, likely due to an elm-doc-test bug when there aren't any doc tests. It's a good template, but wasn't used by this package. I'd prefer a solution that made it work, but I was too lazy at the time. Will work on a proper solution if you want.

It was used by this package. There are multiple doc tests. They likely need to be upgraded to use elm-verify-examples: but they should be upgraded, not dropped.

I see that elm-doc-test has been renamed to elm-verify-examples.

elm-doc-test 4.0.0 creates elm files that don't compile, when there are no doc tests.

The latest version of elm-verify-examples does not have that problem. I'll push a change to use that instead.

These are doc tests: https://github.com/eeue56/elm-xml/blob/master/src/Xml/Decode.elm#L171

Ah. Perhaps at one time ">>>" was the magic prefix for a doc test. Now it is "-->". I've never used them, so I have no memory of when that changed.

https://github.com/stoeffel/elm-verify-examples

Yep. So in order to switch, you'll need to change the syntax of the examples

I figured out what happened. Referencing https://github.com/stoeffel/elm-verify-examples/commits/master :

Jun 14, "Proposal new dsl" changed the syntax.
Jun 16, "Version 4.0.0" (of elm-doc-test) released.
Jun 16, "Renaming to elm-verify-examples".
Jun 17, "Version 1.0.1" (of elm-verify-examples) released.

The Travis script was getting elm-doc-test version 4.0.0, with the new syntax, hence failing.

I added a PR to @myrho's fork to update all the comment tests to the new syntax. Travis is happy in Linux, but still waiting to run the macOS test.

Hopefully, @myrho will check in soon, fix the other issues, and commit to add his and my fixes to this PR.

I also added syconfcpus to the Travis script, to speed "elm make" from minutes to seconds. Yes. It's that amazing.

Just open a new PR against here, no need to merge into the fork

eeue56 · 2017-12-05T12:15:28Z

src/Xml/Decode.elm

@@ -92,19 +101,59 @@ parseSlice first firstClose trimmed =

        closeTag =
            "</" ++ tagName ++ ">"
+
+        openTag =
+            "<" ++ Regex.escape tagName ++ "[\\s\\n]*[^/]*?>" 


Defining regexes at runtime like this can lead to runtime errors, they should instead be defined as flatly as possible, see propRegex. In the cases where they can't, I'd rather not use a regex for that.

eeue56 · 2017-12-05T12:16:31Z

src/Xml/Decode.elm

+            "<" ++ Regex.escape tagName ++ "[\\s\\n]*[^/]*?>" 
+            |> Regex.regex
+
+        openTags =


type signatures here would help make the code readable

eeue56 · 2017-12-05T12:17:09Z

src/Xml/Decode.elm

+                ++ closeTags
+                |> List.sortBy second
+
+        reduce list =


This name doesn't make it obvious to me what this function is meant to do

eeue56 · 2017-12-05T12:17:30Z

src/Xml/Decode.elm

-                else if (String.contains "/>" trimmed) then
-                    Ok ( Tag tagName props (Object []), firstClose + 1 )
+                else if String.endsWith "/" beforeClose then
+                    let tag = if String.endsWith "/" tagName then


this should be on a newline

Sorry. I just started using elm-format. Was naughty about such things in the past. Will fix. By saving in my editor. :)

eeue56

see comments for things I'd like answered before merging. sorry for taking so long, I didn't get a notification for this til today!

eeue56 · 2017-12-06T15:38:01Z

@myrho Would be great if you could rebase this PR on master now that it has updated tests etc :)

myrho and others added 5 commits February 27, 2017 07:50

parse empty elements and comments

579b68f

allow for nested nodes

4d39453

merge, allow tags being nested in themselves

2d0b3a5

reset elm-format changes, reset Doc.Tests thing, bump version

7217aba

Merge pull request #1 from billstclair/master

40ef52d

Parse a self-closing tag with no attributes and no space before '/>'

eeue56 reviewed Dec 5, 2017

View reviewed changes

eeue56 requested changes Dec 5, 2017

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Parse nested tags with equal name (solves #3) #8

Parse nested tags with equal name (solves #3) #8

myrho commented Jun 1, 2017

billstclair commented Dec 5, 2017

billstclair commented Dec 5, 2017

eeue56 Dec 5, 2017

billstclair Dec 5, 2017

eeue56 Dec 5, 2017

billstclair Dec 5, 2017

eeue56 Dec 5, 2017

eeue56 Dec 5, 2017 •

edited

Loading

billstclair Dec 5, 2017

eeue56 Dec 6, 2017

billstclair Dec 6, 2017 •

edited

Loading

eeue56 Dec 6, 2017

eeue56 Dec 5, 2017

eeue56 Dec 5, 2017

eeue56 Dec 5, 2017

eeue56 Dec 5, 2017

billstclair Dec 5, 2017

eeue56 left a comment

eeue56 commented Dec 6, 2017

Parse nested tags with equal name (solves #3) #8

Are you sure you want to change the base?

Parse nested tags with equal name (solves #3) #8

Conversation

myrho commented Jun 1, 2017

billstclair commented Dec 5, 2017

billstclair commented Dec 5, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

eeue56 Dec 5, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

billstclair Dec 6, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

eeue56 left a comment

Choose a reason for hiding this comment

eeue56 commented Dec 6, 2017

eeue56 Dec 5, 2017 •

edited

Loading

billstclair Dec 6, 2017 •

edited

Loading