Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable asyncLocalStorage by default #251

Merged
merged 4 commits into from
Dec 6, 2022
Merged

Conversation

fengmk2
Copy link
Member

@fengmk2 fengmk2 commented Dec 6, 2022

Copy link
Contributor

@killagu killagu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Requests/sec: 17395.81
Transfer/sec: 12.04MB

v12.22.12
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

v12 性能是真的下降很多。

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

毕竟那个版本还没优化 async hook 吧,反正不是我们最小支持版本了

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

毕竟那个版本还没优化 async hook 吧,反正不是我们最小支持版本了

春节之后给 egg-core 发布一个 major 版本,只支持 node 14+

@codecov
Copy link

codecov bot commented Dec 6, 2022

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.75%. Comparing base (f25a1c5) to head (798d976).
Report is 30 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #251   +/-   ##
=======================================
  Coverage   99.75%   99.75%           
=======================================
  Files          19       19           
  Lines        1206     1207    +1     
  Branches      211      211           
=======================================
+ Hits         1203     1204    +1     
  Misses          3        3           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fengmk2 fengmk2 merged commit 0e48956 into master Dec 6, 2022
@fengmk2 fengmk2 deleted the support-asyncLocalStorage branch December 6, 2022 14:46
@fengmk2
Copy link
Member Author

fengmk2 commented Dec 6, 2022

4.29.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants