Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: impl Host decorator #48

Merged
merged 1 commit into from
Aug 16, 2022
Merged

feat: impl Host decorator #48

merged 1 commit into from
Aug 16, 2022

Conversation

killagu
Copy link
Contributor

@killagu killagu commented Aug 16, 2022

Checklist
  • npm test passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)
Description of change

@codecov
Copy link

codecov bot commented Aug 16, 2022

Codecov Report

Merging #48 (6e7d23f) into master (cd8c3cb) will increase coverage by 0.14%.
The diff coverage is 100.00%.

❗ Current head 6e7d23f differs from pull request most recent head 8d61bb5. Consider uploading reports for the commit 8d61bb5 to get more accurate results

@@            Coverage Diff             @@
##           master      #48      +/-   ##
==========================================
+ Coverage   91.90%   92.05%   +0.14%     
==========================================
  Files         198      199       +1     
  Lines        4040     4115      +75     
  Branches      388      397       +9     
==========================================
+ Hits         3713     3788      +75     
  Misses        326      326              
  Partials        1        1              
Impacted Files Coverage Δ
core/controller-decorator/index.ts 100.00% <100.00%> (ø)
...re/controller-decorator/src/decorator/http/Host.ts 100.00% <100.00%> (ø)
...corator/src/impl/http/HTTPControllerMetaBuilder.ts 95.83% <100.00%> (+0.08%) ⬆️
...r/src/impl/http/HTTPControllerMethodMetaBuilder.ts 94.44% <100.00%> (+0.07%) ⬆️
...ntroller-decorator/src/model/HTTPControllerMeta.ts 100.00% <100.00%> (ø)
...e/controller-decorator/src/model/HTTPMethodMeta.ts 95.00% <100.00%> (+0.08%) ⬆️
...ontroller-decorator/src/util/ControllerInfoUtil.ts 100.00% <100.00%> (ø)
...re/controller-decorator/src/util/MethodInfoUtil.ts 100.00% <100.00%> (ø)
plugin/controller/lib/RootProtoManager.ts 95.00% <100.00%> (+2.14%) ⬆️
...controller/lib/impl/http/HTTPControllerRegister.ts 100.00% <100.00%> (ø)
... and 3 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@killagu killagu merged commit 65dc7a8 into master Aug 16, 2022
@killagu killagu deleted the feat/http_host branch August 16, 2022 16:16
@killagu
Copy link
Contributor Author

killagu commented Aug 16, 2022

@atian25
Copy link
Member

atian25 commented Aug 17, 2022

有 bug,在 f416ed7 修复了

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants