-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Implement submit_windowed_post extrinsic #113
feat: Implement submit_windowed_post extrinsic #113
Conversation
7c47e6b
to
cc63d91
Compare
16d7ca6
to
f493af2
Compare
…ovider-pallet-proof-of-spacetime
…ovider-pallet-proof-of-spacetime
e824f9d
to
55143d2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Preliminary questions and notes
f79e4f5
to
2acf3ce
Compare
01bc538
to
1826fb4
Compare
…ovider-pallet-proof-of-spacetime
27928ac
to
7f8e785
Compare
63af95e
to
5f3df95
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good work 💪
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's merge this and do any leftover improvements as a result of further development. Good job!
93ecd05
to
569bbf9
Compare
569bbf9
to
4ed68dd
Compare
Description
Implement the
submit_windowed_post
extrinsic, allowing an SP to submit their Proof-of-Spacetime. The validation of the proof is stubbed out. I am not sure if always returning true is the way to go for now or having some type of failure condition is preferred, I am open to suggestions.Important points for reviewers
Filecoin implementation reference
Checklist
Proofs are not validated at the moment so the
validate_windowed_post
always returns true on the submitted proof.SP pallet (hooks): pre-commit hook #103 will check that the Proof-of-Spacetime is submitted on time.
I did not write a test for this as it always returns true for every proof