Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Implement submit_windowed_post extrinsic #113

Merged
merged 90 commits into from
Jul 29, 2024

Conversation

aidan46
Copy link
Contributor

@aidan46 aidan46 commented Jul 3, 2024

Description

Implement the submit_windowed_post extrinsic, allowing an SP to submit their Proof-of-Spacetime. The validation of the proof is stubbed out. I am not sure if always returning true is the way to go for now or having some type of failure condition is preferred, I am open to suggestions.

Important points for reviewers

Filecoin implementation reference

Checklist

  • Are there important points that reviewers should know?
    • If yes, which ones?
      Proofs are not validated at the moment so the validate_windowed_post always returns true on the submitted proof.
  • If there are follow-ups, have you created issues for them?
  • Have you tested this solution?
    I did not write a test for this as it always returns true for every proof
  • Did you document new (or modified) APIs?

pallets/storage-provider/src/lib.rs Outdated Show resolved Hide resolved
pallets/storage-provider/src/proofs.rs Outdated Show resolved Hide resolved
pallets/storage-provider/src/proofs.rs Show resolved Hide resolved
pallets/storage-provider/src/proofs.rs Outdated Show resolved Hide resolved
pallets/storage-provider/src/proofs.rs Show resolved Hide resolved
@aidan46 aidan46 force-pushed the feat-74-storage-provider-pallet-proof-of-spacetime branch 2 times, most recently from 7c47e6b to cc63d91 Compare July 5, 2024 11:31
@aidan46 aidan46 force-pushed the feat-95-storage-provider-pallet-implement-prove-commit-sector branch from 16d7ca6 to f493af2 Compare July 9, 2024 16:14
Base automatically changed from feat-95-storage-provider-pallet-implement-prove-commit-sector to develop July 10, 2024 20:52
@aidan46 aidan46 marked this pull request as draft July 11, 2024 12:28
@aidan46 aidan46 force-pushed the feat-74-storage-provider-pallet-proof-of-spacetime branch from e824f9d to 55143d2 Compare July 15, 2024 12:52
Copy link
Contributor

@jmg-duarte jmg-duarte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Preliminary questions and notes

pallets/storage-provider/src/deadline.rs Outdated Show resolved Hide resolved
pallets/storage-provider/src/deadline.rs Outdated Show resolved Hide resolved
pallets/storage-provider/src/deadline.rs Outdated Show resolved Hide resolved
pallets/storage-provider/src/deadline.rs Outdated Show resolved Hide resolved
pallets/storage-provider/src/partition.rs Outdated Show resolved Hide resolved
pallets/storage-provider/src/partition.rs Outdated Show resolved Hide resolved
pallets/storage-provider/src/partition.rs Show resolved Hide resolved
pallets/storage-provider/src/partition.rs Outdated Show resolved Hide resolved
@aidan46 aidan46 force-pushed the feat-74-storage-provider-pallet-proof-of-spacetime branch 6 times, most recently from f79e4f5 to 2acf3ce Compare July 16, 2024 16:30
@aidan46 aidan46 force-pushed the feat-74-storage-provider-pallet-proof-of-spacetime branch from 01bc538 to 1826fb4 Compare July 18, 2024 12:30
@aidan46 aidan46 force-pushed the feat-74-storage-provider-pallet-proof-of-spacetime branch 2 times, most recently from 27928ac to 7f8e785 Compare July 22, 2024 10:34
@aidan46 aidan46 force-pushed the feat-74-storage-provider-pallet-proof-of-spacetime branch from 63af95e to 5f3df95 Compare July 22, 2024 12:12
@aidan46 aidan46 requested a review from jmg-duarte July 29, 2024 12:07
cernicc
cernicc previously approved these changes Jul 29, 2024
Copy link
Member

@cernicc cernicc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good work 💪

jmg-duarte
jmg-duarte previously approved these changes Jul 29, 2024
Copy link
Contributor

@jmg-duarte jmg-duarte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's merge this and do any leftover improvements as a result of further development. Good job!

@jmg-duarte jmg-duarte added ready for review Review is needed and removed ready for review Review is needed labels Jul 29, 2024
@aidan46 aidan46 dismissed stale reviews from jmg-duarte and cernicc via 93ecd05 July 29, 2024 12:32
@aidan46 aidan46 added ready for review Review is needed and removed ready for review Review is needed labels Jul 29, 2024
@aidan46 aidan46 force-pushed the feat-74-storage-provider-pallet-proof-of-spacetime branch from 93ecd05 to 569bbf9 Compare July 29, 2024 12:33
@aidan46 aidan46 added ready for review Review is needed and removed ready for review Review is needed labels Jul 29, 2024
@aidan46 aidan46 force-pushed the feat-74-storage-provider-pallet-proof-of-spacetime branch from 569bbf9 to 4ed68dd Compare July 29, 2024 12:35
@aidan46 aidan46 added ready for review Review is needed and removed ready for review Review is needed labels Jul 29, 2024
@aidan46 aidan46 added ready for review Review is needed and removed ready for review Review is needed labels Jul 29, 2024
@jmg-duarte jmg-duarte requested a review from cernicc July 29, 2024 14:32
pallets/storage-provider/src/deadline.rs Outdated Show resolved Hide resolved
pallets/storage-provider/src/deadline.rs Show resolved Hide resolved
pallets/storage-provider/src/deadline.rs Show resolved Hide resolved
pallets/storage-provider/src/deadline.rs Show resolved Hide resolved
@jmg-duarte jmg-duarte merged commit f4a9591 into develop Jul 29, 2024
3 checks passed
@jmg-duarte jmg-duarte deleted the feat-74-storage-provider-pallet-proof-of-spacetime branch July 29, 2024 14:46
@th7nder th7nder linked an issue Jul 30, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review Review is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Storage Provider Pallet: Submit Proof of Spacetime Extrinsic
5 participants