[fleche] Reject opening multiple Coq documents for buggy Coq versions. #287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ejgallego
force-pushed
the
fail_hard_on_some_docs
branch
3 times, most recently
from
c26a6cf to
3f36a86
Compare
|
I will merge this (and release 0.1.5) when the branches noted in the README are ready. |
|
@Alizter what do you think of this? |
Alizter
approved these changes
Feb 6, 2023
|
Logic seems sound, but I haven't tested it myself. |
Thanks for the feedback @Alizter , indeed logic seems to work, I have done some testing, and IMHO it is a much better experience that what we have today; I hope the error message is Ok for users. I'm waiting to see what's the outcome of coq/coq#17200 just in case we would only need this for the 8.16 branch. |
ejgallego
force-pushed
the
fail_hard_on_some_docs
branch
from
3f36a86 to
6dd0231
Compare
|
Merging now, we can adjust the notes once we discuss about the Coq backport, before release (no point on holding this due to code conflicts) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #275 , fixes #281
We use a heuristic in the fixed up branches as follows: if the Coq version contains LSP, then we assume the fix has been backported.
That should work when doing
opam pin.