Missing C bindings + revamp composition with opaque vectors #382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #382 +/- ##
==========================================
+ Coverage 85.48% 85.91% +0.43%
==========================================
Files 36 36
Lines 4415 4444 +29
==========================================
+ Hits 3774 3818 +44
+ Misses 641 626 -15
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
elalish
approved these changes
Mar 20, 2023
| return ms; | ||
| ManifoldManifoldVec *manifold_decompose(void *mem, ManifoldManifold *m) { | ||
| auto comps = from_c(m)->Decompose(); | ||
| return to_c(new (mem) std::vector<Manifold>(comps)); |
| @@ -75,9 +75,6 @@ class Manifold { | |||
| */ | |||
| ///@{ | |||
| static Manifold Compose(const std::vector<Manifold>&); | |||
|
|
|||
| Components GetComponents() const; | |||
| std::vector<Manifold> Decompose(Components components) const; | |||
Merged
cartesian-theatrics
pushed a commit
to SovereignShop/manifold
that referenced
this pull request
Mar 11, 2024
…ish#382) - Add bindings to `CrossSection::{Compose,Decompose,NumVert,NumContour,Warp}` - Add bindings to `Boolean` and `BatchBoolean` for both `Manifold` and `CrossSection` - Add `ManifoldManifoldVec` and `ManifoldCrossSectionVec` opaque types for `std::vector` pointers to help clean up bindings involving vectors (particularly when they are returned with dynamic size, *e.g.* `manifold_decompose` - Remove two-step Components workaround previously introduced to allow return of C array from `manifold_decompose`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This brings the C bindings up to date with the latest additions to
CrossSectionas well as adding a couple that were missing from theManifoldcoverage as well (BooleanandBatchBoolean).With the addition of
CrossSection'sDecompose, I decided I should take the opportunity to remedy some silliness I introduced with the multistepDecomposedue to my desire to stick with arrays uniformly, without using an opaque vector API. NowDecomposefor both classes returns an opaque vector, and the basic methods have been added to support this.