Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

V2.2.1 #589

Merged
merged 3 commits into from
Nov 3, 2023
Merged

V2.2.1 #589

merged 3 commits into from
Nov 3, 2023

Conversation

pca006132
Copy link
Collaborator

@pca006132 pca006132 commented Nov 2, 2023 •
edited
Loading

V2.2.1 release. I updated the versions, added npm and PyPI badges, and removed the old performance plot because it is too outdated now. I also updated the documentation of extrude to close #563.

This is V2.2.1 because I accidentally published V2.2.0 on PyPI, so V2.2.0 will require removing one version in PyPI which I try not to do.

@pca006132
added notes about twistDegree and nDivisions
34598f5
@pca006132
update version
c1d6510
@pca006132
removed perf comparison figure
505a9c9 
it is pretty outdated considering we don't have the GPU backend anymore
and performance is different now.
@pca006132 pca006132 requested a review from elalish November 2, 2023 20:22
@codecov Codecov
Copy link

codecov bot commented Nov 2, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5930b5c) 91.41% compared to head (505a9c9) 91.41%.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master     #589   +/-   ##
=======================================
  Coverage   91.41%   91.41%           
=======================================
  Files          35       35           
  Lines        4496     4496           
=======================================
  Hits         4110     4110           
  Misses        386      386
Files Coverage Δ
src/manifold/src/constructors.cpp 96.39% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

elalish
elalish approved these changes Nov 2, 2023
View reviewed changes
Copy link
Owner

@elalish elalish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for putting this together! I'm compiling release notes - I'll paste them in a comment here so you can take a look before I put them in a Github release. Also, do you think we should include any files in the Github release itself? I vaguely recall talking about that one time.

flake.nix
@@ -134,7 +134,7 @@
# but how should we make it work with other python versions?
manifold3d = with pkgs.python3Packages; buildPythonPackage {
pname = "manifold3d";
version = "2.2.0";
version = "2.2.1";
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think it would be worthwhile to build a little release script to update all the version numbers and ensure they're consistent?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sounds good

@pca006132
Copy link
Collaborator Author

I'll paste them in a comment here so you can take a look before I put them in a Github release.

Sure. Maybe we should put this in the repo as well? You can just update this PR I think.

Also, do you think we should include any files in the Github release itself?

What files? I forgot about this.

@elalish
Copy link
Owner

elalish commented Nov 3, 2023 •
edited
Loading

Release notes - I've never seen them checked into a repo; I generally just put them here. I won't worry about files - looks like Github automatically attaches the source code zip file anyway. Do these release notes look decent? We did a lot...

This is another significant update, bringing 2D support, lossless roundtrip of Manifolds through glTF, Python bindings published on PyPI, and a whole new triangulator that fixes lots of geometric edge cases in the Boolean. And of course many bug fixes and performance improvements - a huge thank you to all the contributors!

New Features

Bindings

Bug Fixes

Performance Improvements

Build/CI Updates

Examples

ManifoldCAD.org

@pca006132
Copy link
Collaborator Author

You added one more backtick for convertFile utility in Examples section. Other than that it looks good to me. This is a lot of stuff for half a year!

@elalish elalish merged commit bb6acf1 into elalish:master Nov 3, 2023
@elalish
Copy link
Owner

elalish commented Nov 3, 2023 •
edited
Loading

Okay, I did the Github and npm releases. Did you see the failed actions in uploading to PyPI? It looks like it's having trouble with the wheels OS matrix, because the first one succeeds, but the following ones fail to publish because they already exist. Maybe a names thing? I don't know much about Python packaging...

FYI I'm going to bed now.

@pca006132
Copy link
Collaborator Author

it seems that it is published, but for some reason the release triggered 3 actions and attempts to publish 3 times.

cartesian-theatrics pushed a commit to SovereignShop/manifold that referenced this pull request Mar 11, 2024
@pca006132
V2.2.1 (elalish#589)
e492e8d 
* added notes about twistDegree and nDivisions

* update version

* removed perf comparison figure

it is pretty outdated considering we don't have the GPU backend anymore
and performance is different now.
@pca006132 pca006132 deleted the v2.2.1 branch November 16, 2024 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elalish elalish elalish approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

extrude twist can cause invalid geometry
2 participants
@pca006132 @elalish