fix warp simplification #416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pca006132
approved these changes
Apr 20, 2023
|
LGTM. It seems that the test failure is due to floating point error? |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #416 +/- ##
=======================================
Coverage 86.08% 86.09%
=======================================
Files 38 38
Lines 4601 4603 +2
=======================================
+ Hits 3961 3963 +2
Misses 640 640
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
Merged
Merged
cartesian-theatrics
pushed a commit
to SovereignShop/manifold
that referenced
this pull request
Mar 11, 2024
* fixed warp simplification * fix test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #413
Our simplification is driven by what faces are marked as coplanar, but
Warpis in general nonlinear, so coplanarity must be re-evaluated.Warpwas also not simplifying, so this problem would only be seen after another op like a Boolean or Compose that calls simplify. Both of these problems are fixed, with a test added.