-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix compose index error #430
Conversation
Btw is there a way I can avoid GitHub from auto-closing the linked issue? |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #430 +/- ##
=======================================
Coverage 89.73% 89.74%
=======================================
Files 35 35
Lines 4200 4201 +1
=======================================
+ Hits 3769 3770 +1
Misses 431 431
☔ View full report in Codecov by Sentry. |
Yes, just avoid the word "Fixes". Maybe something like "partially addresses". Also, that bug is pretty convoluted - nothing wrong with closing it and starting a more specific one. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good find, thanks!
* fix compose index error elalish#425 (comment) * simplify test case
Fixes #425 (comment)
Also, for #429, it seems that the error is now: