Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Heartbeat] Support de-duped screenshots #26188

Closed
andrewvc opened this issue Jun 7, 2021 · 1 comment · Fixed by #25808
Closed

[Heartbeat] Support de-duped screenshots #26188

andrewvc opened this issue Jun 7, 2021 · 1 comment · Fixed by #25808
Assignees
@andrewvc
Labels
enhancement Heartbeat Team:obs-ds-hosted-services Label for the Observability Hosted Services team

Comments

@andrewvc
Copy link
Contributor

andrewvc commented Jun 7, 2021

This is the counterpart of elastic/synthetics#282 for heartbeat. We need to support de-duped screenshots, and while we're in dev, allow users to override config flags to test this out.
@andrewvc andrewvc added enhancement Heartbeat [zube]: In Review Team:obs-ds-hosted-services Label for the Observability Hosted Services team labels Jun 7, 2021
@andrewvc andrewvc self-assigned this Jun 7, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/uptime (Team:Uptime)

@andrewvc andrewvc mentioned this issue Jun 7, 2021
Merged
@andrewvc andrewvc mentioned this issue Jun 10, 2021
Merged
3 tasks
andrewvc added a commit that referenced this issue Jun 10, 2021
@andrewvc
[Heartbeat] Fix broken invocation of synth package (#26228)
ad7c19f 
Fixes invocation of synthetics broken in #26188

Additionally, for dev purposes, this lets accepts a synthetics version of file:/// as valid to help with debugging development versions of the synthetics agent.

Never released, so no changelog needed

Still just sticking with unit tests here since testing more deeply with synthetics (esp. master where this is a problem) is a larger problem than we're equipped to handle ATM.
mergify bot pushed a commit that referenced this issue Jun 10, 2021
@andrewvc
[Heartbeat] Fix broken invocation of synth package (#26228)
28744fc 
Fixes invocation of synthetics broken in #26188

Additionally, for dev purposes, this lets accepts a synthetics version of file:/// as valid to help with debugging development versions of the synthetics agent.

Never released, so no changelog needed

Still just sticking with unit tests here since testing more deeply with synthetics (esp. master where this is a problem) is a larger problem than we're equipped to handle ATM.

(cherry picked from commit ad7c19f)

# Conflicts:
#	x-pack/heartbeat/monitors/browser/source/validatepackage.go
#	x-pack/heartbeat/monitors/browser/source/validatepackage_test.go
andrewvc added a commit that referenced this issue Jul 27, 2021
@mergify @andrewvc
[Heartbeat] Fix broken invocation of synth package (backport #26228) (#…
5f49358 
…26250)

* [Heartbeat] Fix broken invocation of synth package (#26228)

Fixes invocation of synthetics broken in #26188

Additionally, for dev purposes, this lets accepts a synthetics version of file:/// as valid to help with debugging development versions of the synthetics agent.

Never released, so no changelog needed

Still just sticking with unit tests here since testing more deeply with synthetics (esp. master where this is a problem) is a larger problem than we're equipped to handle ATM.

(cherry picked from commit ad7c19f)

# Conflicts:
#	x-pack/heartbeat/monitors/browser/source/validatepackage.go
#	x-pack/heartbeat/monitors/browser/source/validatepackage_test.go

* Fix license

* Fix notice

Co-authored-by: Andrew Cholakian <[email protected]>
mergify bot added a commit that referenced this issue Jul 27, 2021
@mergify
[Heartbeat] Fix broken invocation of synth package (backport #26228) (#…
86cb447 
…26250)

* [Heartbeat] Fix broken invocation of synth package (#26228)

Fixes invocation of synthetics broken in #26188

Additionally, for dev purposes, this lets accepts a synthetics version of file:/// as valid to help with debugging development versions of the synthetics agent.

Never released, so no changelog needed

Still just sticking with unit tests here since testing more deeply with synthetics (esp. master where this is a problem) is a larger problem than we're equipped to handle ATM.

(cherry picked from commit ad7c19f)

# Conflicts:
#	x-pack/heartbeat/monitors/browser/source/validatepackage.go
#	x-pack/heartbeat/monitors/browser/source/validatepackage_test.go

* Fix license

* Fix notice

Co-authored-by: Andrew Cholakian <[email protected]>
(cherry picked from commit 5f49358)
andrewvc pushed a commit that referenced this issue Jul 27, 2021
@mergify
[Heartbeat] Fix broken invocation of synth package (backport #26228) (#…
b051860 
…26250) (#27083)

* [Heartbeat] Fix broken invocation of synth package (#26228)

Fixes invocation of synthetics broken in #26188

Additionally, for dev purposes, this lets accepts a synthetics version of file:/// as valid to help with debugging development versions of the synthetics agent.

Never released, so no changelog needed

Still just sticking with unit tests here since testing more deeply with synthetics (esp. master where this is a problem) is a larger problem than we're equipped to handle ATM.

(cherry picked from commit ad7c19f)

# Conflicts:
#	x-pack/heartbeat/monitors/browser/source/validatepackage.go
#	x-pack/heartbeat/monitors/browser/source/validatepackage_test.go

* Fix license

* Fix notice

Co-authored-by: Andrew Cholakian <[email protected]>
(cherry picked from commit 5f49358)

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andrewvc andrewvc

Labels
enhancement Heartbeat Team:obs-ds-hosted-services Label for the Observability Hosted Services team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Heartbeat] Dedupe screenshots / Extra Args andrewvc/beats
3 participants
@andrewvc @elasticmachine @paulb-elastic