[Heartbeat] Fix broken invocation of synth package (backport #26228) #26250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
Fixes invocation of synthetics broken in #26188 Additionally, for dev purposes, this lets accepts a synthetics version of file:/// as valid to help with debugging development versions of the synthetics agent. Never released, so no changelog needed Still just sticking with unit tests here since testing more deeply with synthetics (esp. master where this is a problem) is a larger problem than we're equipped to handle ATM. (cherry picked from commit ad7c19f) # Conflicts: # x-pack/heartbeat/monitors/browser/source/validatepackage.go # x-pack/heartbeat/monitors/browser/source/validatepackage_test.go
mergify
bot
added
the
conflicts
botelastic
bot
added
the
needs_team
3 tasks
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪💚 Flaky test reportTests succeeded. Expand to view the summary
Test stats 🧪
|
jsoriano
added
the
Team:obs-ds-hosted-services
|
Pinging @elastic/uptime (Team:Uptime) |
botelastic
bot
removed
the
needs_team
|
/test |
|
@Mergifyio backport 7.14 |
|
Command
|
|
This pull request is now in conflicts. Could you fix it? 🙏 |
|
/test |
|
@Mergifyio backport 7.14 |
mergify bot
added a commit
that referenced
this pull request
Jul 27, 2021
…26250) * [Heartbeat] Fix broken invocation of synth package (#26228) Fixes invocation of synthetics broken in #26188 Additionally, for dev purposes, this lets accepts a synthetics version of file:/// as valid to help with debugging development versions of the synthetics agent. Never released, so no changelog needed Still just sticking with unit tests here since testing more deeply with synthetics (esp. master where this is a problem) is a larger problem than we're equipped to handle ATM. (cherry picked from commit ad7c19f) # Conflicts: # x-pack/heartbeat/monitors/browser/source/validatepackage.go # x-pack/heartbeat/monitors/browser/source/validatepackage_test.go * Fix license * Fix notice Co-authored-by: Andrew Cholakian <[email protected]> (cherry picked from commit 5f49358)
|
Command
|
1 similar comment
|
Command
|
andrewvc
pushed a commit
that referenced
this pull request
Jul 27, 2021
…26250) (#27083) * [Heartbeat] Fix broken invocation of synth package (#26228) Fixes invocation of synthetics broken in #26188 Additionally, for dev purposes, this lets accepts a synthetics version of file:/// as valid to help with debugging development versions of the synthetics agent. Never released, so no changelog needed Still just sticking with unit tests here since testing more deeply with synthetics (esp. master where this is a problem) is a larger problem than we're equipped to handle ATM. (cherry picked from commit ad7c19f) # Conflicts: # x-pack/heartbeat/monitors/browser/source/validatepackage.go # x-pack/heartbeat/monitors/browser/source/validatepackage_test.go * Fix license * Fix notice Co-authored-by: Andrew Cholakian <[email protected]> (cherry picked from commit 5f49358) Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of pull request #26228 done by Mergify.
Cherry-pick of ad7c19f has failed:
To fix up this pull request, you can check it out locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refreshwill re-evaluate the rules@Mergifyio rebasewill rebase this PR on its base branch@Mergifyio updatewill merge the base branch into this PR@Mergifyio backport <destination>will backport this PR on<destination>branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.io/