-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Filebeat - Modules Apache - Error : Fix Client IP - missing PORT #12695
Conversation
http://httpd.apache.org/docs/current/mod/core.html#errorlog Default : ErrorLogFormat "[%t] [%l] [pid %P] %F: %E: [client %a] %M" %a = Client IP address and port of the request
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for investigating this issue and proposing a fix!
Could you also provide a test file that reproduces this issue? This should be added to filebeat/module/apache/error/test/
directory, you can find other examples there.
Hello @jsoriano This is JSON view in Kibana
We see that in message the "client" part is not extracted |
Add test for client IP:PORT
Co-Authored-By: Jaime Soriano Pastor <[email protected]>
Co-Authored-By: Jaime Soriano Pastor <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@wixaw thanks for testing my proposal, actually you are right and my change wouldn't be enough because there are additional processors expecting source.address
to be just an ip or a host.
Neither works. When I modify the pipeline.json and I restart filebeat (centos 7) nothing changes
Is this compiled somewhere?
The pipeline needs to be installed in Elasticsearch using filebeat setup
.
Here is my log of example:
[Thu Jun 27 06:58:09.169510 2019] [include:warn] [pid 15934] [client 123.123.123.123:12345] AH01374: mod_include: Options +Includes (or IncludesNoExec) wasn't set, INCLUDES filter removed: /test.html
Thanks!
Co-Authored-By: Jaime Soriano Pastor <[email protected]>
Co-Authored-By: Jaime Soriano Pastor <[email protected]>
Yesss
|
@wixaw merged, thanks! |
…tic#12695) Client addresses can contain the port in the default log format, add support for this. (cherry picked from commit fa8c467)
…tic#12695) Client addresses can contain the port in the default log format, add support for this. (cherry picked from commit fa8c467)
…tic#12695) Client addresses can contain the port in the default log format, add support for this. (cherry picked from commit fa8c467)
… in Apache error logs (#12729) Client addresses can contain the port in the default log format, add support for this. (cherry picked from commit fa8c467) Co-authored-by: William VINCENT <[email protected]>
… in Apache error logs (#12730) Client addresses can contain the port in the default log format, add support for this. (cherry picked from commit fa8c467) Co-authored-by: William VINCENT <[email protected]>
… in Apache error logs (#12731) Client addresses can contain the port in the default log format, add support for this. (cherry picked from commit fa8c467) Co-authored-by: William VINCENT <[email protected]>
…th port in Apache error logs (elastic#12729) Client addresses can contain the port in the default log format, add support for this. (cherry picked from commit b81c58c) Co-authored-by: William VINCENT <[email protected]>
…th port in Apache error logs (elastic#12730) Client addresses can contain the port in the default log format, add support for this. (cherry picked from commit b81c58c) Co-authored-by: William VINCENT <[email protected]>
…th port in Apache error logs (elastic#12731) Client addresses can contain the port in the default log format, add support for this. (cherry picked from commit b81c58c) Co-authored-by: William VINCENT <[email protected]>
http://httpd.apache.org/docs/current/mod/core.html#errorlog
Default : ErrorLogFormat "[%t] [%l] [pid %P] %F: %E: [client %a] %M"
%a = Client IP address and port of the request