Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick #12695 to 7.0: Filebeat - Modules Apache - Error : Fix Client IP - missing PORT #12731

Merged
merged 2 commits into from
Jul 4, 2019

Conversation

jsoriano
Copy link
Member

@jsoriano jsoriano commented Jul 1, 2019

Cherry-pick of PR #12695 to 7.0 branch. Original message:

http://httpd.apache.org/docs/current/mod/core.html#errorlog

Default : ErrorLogFormat "[%t] [%l] [pid %P] %F: %E: [client %a] %M"
%a = Client IP address and port of the request

@jsoriano jsoriano requested a review from a team as a code owner July 1, 2019 09:35
…tic#12695)

Client addresses can contain the port in the default log format,
add support for this.

(cherry picked from commit fa8c467)
sayden
sayden previously requested changes Jul 1, 2019
Copy link
Contributor

@sayden sayden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

;)

- Add ISO8601 date parsing support for system module. {pull}12568[12568] {pull}12578[12579]
- Use correct OS path separator in `add_kubernetes_metadata` to support Windows nodes. {pull}9205[9205]
- Add support for client addresses with port in Apache error logs {pull}12695[12695]

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check Changelog

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You were fast 🙂 fixed!

@jsoriano jsoriano force-pushed the backport_12695_7.0 branch from 45c7164 to d36a6ca Compare July 1, 2019 10:01
@jsoriano
Copy link
Member Author

jsoriano commented Jul 2, 2019

@sayden could you take another look? Thanks!

@jsoriano jsoriano dismissed sayden’s stale review July 4, 2019 11:30

Requested changes were addressed

@jsoriano jsoriano merged commit 472b05a into elastic:7.0 Jul 4, 2019
@jsoriano jsoriano deleted the backport_12695_7.0 branch July 4, 2019 11:31
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
…th port in Apache error logs (elastic#12731)

Client addresses can contain the port in the default log format,
add support for this.

(cherry picked from commit b81c58c)

Co-authored-by: William VINCENT <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants