-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include log.source.address for unparseable syslog messages #13274
Conversation
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
1 similar comment
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
ok to test |
Can this move forward? This is causing us significant problems in our environment |
This will need a changelog entry. @ph could you also take a look to this change? Thanks! |
LGTM, need a changelog entry and a test |
Not having this is causing issues in our environment as its basically impossible to tell where the log message that is invalid came from... |
@candlerb could you add the test and the changelog entry? If you don't have time it is ok, we can also continue with this change. Thanks! |
Sorry, at the time I couldn't see an easy way to add a test to this without big refactoring, in a codebase I wasn't familiar with. |
Fixes #13268