Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick #15453 to 7.5: Include log.source.address for unparseable syslog messages #15495

Merged
merged 2 commits into from
Jan 15, 2020

Conversation

jsoriano
Copy link
Member

Cherry-pick of PR #15453 to 7.5 branch. Original message:

Continues with #13274, fixes #13268.

How to test:

  • Start filebeat with the syslog input
  • Send an invalid message to the open port
  • Check that the generated event for the invalid message includes the source address

Co-authored-by: Brian Candler [email protected]

…5453)

Source address was being included in syslog events, but if
the syslog message failed to be parsed the event was being
generated without this information. Add it in any case.

Co-authored-by: Brian Candler <[email protected]>
(cherry picked from commit d552e90)
Copy link
Contributor

@ph ph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jsoriano
Copy link
Member Author

jenkins, test this again please

@ycombinator ycombinator merged commit 3265a93 into elastic:7.5 Jan 15, 2020
@jsoriano jsoriano deleted the backport_15453_7.5 branch January 15, 2020 12:17
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
…rseable syslog messages (elastic#15495)

* Include log.source.address for unparseable syslog messages (elastic#15453)

Source address was being included in syslog events, but if
the syslog message failed to be parsed the event was being
generated without this information. Add it in any case.

Co-authored-by: Brian Candler <[email protected]>
(cherry picked from commit f16fdb1)

* Fix changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants