-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for intel.log zeek module #14404
Conversation
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
1 similar comment
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
Pinging @elastic/siem (Team:SIEM) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you have any log samples that can be included in the fileset for testing purposes? Those can be placed in zeek/intel/test/*.log
.
Enrich the elastic#14150 supporting intel.log Co-Authored-By: Arcuri Davide <[email protected]>
Co-Authored-By: Arcuri Davide <[email protected]>
example intel.log Co-Authored-By: Arcuri Davide <[email protected]>
added default_field: false Co-Authored-By: Arcuri Davide <[email protected]>
2357ff6
to
8243c87
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I pushed an update to add the generated test log output and a changelog entry.
jenkins, test this |
jenkins, test this |
Expand dots in zeek.intel.seen Parse ts value without dropping millisecond value Add event.ingested timestamp Convert ingest node pipeline to YAML Save JSON message in event.original
Expand dots of all seen.* fields Change name of zeek.intel.seen.fa_file to zeek.intel.seen.f as documented by Zeek.
jenkins, test this Will wait for CI to test these changes again then I'll merge it. Thanks! |
* Added support for intel.log zeek module Enrich the elastic#14150 supporting intel.log Co-Authored-By: Arcuri Davide <[email protected]> * Update fields.yml Co-Authored-By: Arcuri Davide <[email protected]> * intel.log example intel.log Co-Authored-By: Arcuri Davide <[email protected]> * added default_field: false added default_field: false Co-Authored-By: Arcuri Davide <[email protected]> * Generate expected zeek/intel output event * Add changelog entry * Update field docs * Misc improvements Expand dots in zeek.intel.seen Parse ts value without dropping millisecond value Add event.ingested timestamp Convert ingest node pipeline to YAML Save JSON message in event.original * Updates to zeek.intel.seen Expand dots of all seen.* fields Change name of zeek.intel.seen.fa_file to zeek.intel.seen.f as documented by Zeek. * Update field docs (cherry picked from commit 7ad14e6)
* Added support for intel.log zeek module Enrich the #14150 supporting intel.log Co-Authored-By: Arcuri Davide <[email protected]> * Update fields.yml Co-Authored-By: Arcuri Davide <[email protected]> * intel.log example intel.log Co-Authored-By: Arcuri Davide <[email protected]> * added default_field: false added default_field: false Co-Authored-By: Arcuri Davide <[email protected]> * Generate expected zeek/intel output event * Add changelog entry * Update field docs * Misc improvements Expand dots in zeek.intel.seen Parse ts value without dropping millisecond value Add event.ingested timestamp Convert ingest node pipeline to YAML Save JSON message in event.original * Updates to zeek.intel.seen Expand dots of all seen.* fields Change name of zeek.intel.seen.fa_file to zeek.intel.seen.f as documented by Zeek. * Update field docs (cherry picked from commit 7ad14e6)
Enrich the #14150 supporting intel.log
Co-Authored-By: Arcuri Davide [email protected]