-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Zeek module addon #14150
Zeek module addon #14150
Conversation
…zeek-module-addon. Original commits were done by @Xander33.
…pipelines. Generate documentation. Add expected test results
jenkins, test this |
There are some unrelated build test failures on iis, nginx, etc. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I left a few comments with doubts and some small mistakes.
jenkins, test this |
…zeek-module-addon
Pinging @elastic/siem (Team:SIEM) |
Enrich the elastic#14150 supporting intel.log Co-Authored-By: Arcuri Davide <[email protected]>
* Added support for intel.log zeek module Enrich the #14150 supporting intel.log Co-Authored-By: Arcuri Davide <[email protected]> * Update fields.yml Co-Authored-By: Arcuri Davide <[email protected]> * intel.log example intel.log Co-Authored-By: Arcuri Davide <[email protected]> * added default_field: false added default_field: false Co-Authored-By: Arcuri Davide <[email protected]> * Generate expected zeek/intel output event * Add changelog entry * Update field docs * Misc improvements Expand dots in zeek.intel.seen Parse ts value without dropping millisecond value Add event.ingested timestamp Convert ingest node pipeline to YAML Save JSON message in event.original * Updates to zeek.intel.seen Expand dots of all seen.* fields Change name of zeek.intel.seen.fa_file to zeek.intel.seen.f as documented by Zeek. * Update field docs
* Added support for intel.log zeek module Enrich the elastic#14150 supporting intel.log Co-Authored-By: Arcuri Davide <[email protected]> * Update fields.yml Co-Authored-By: Arcuri Davide <[email protected]> * intel.log example intel.log Co-Authored-By: Arcuri Davide <[email protected]> * added default_field: false added default_field: false Co-Authored-By: Arcuri Davide <[email protected]> * Generate expected zeek/intel output event * Add changelog entry * Update field docs * Misc improvements Expand dots in zeek.intel.seen Parse ts value without dropping millisecond value Add event.ingested timestamp Convert ingest node pipeline to YAML Save JSON message in event.original * Updates to zeek.intel.seen Expand dots of all seen.* fields Change name of zeek.intel.seen.fa_file to zeek.intel.seen.f as documented by Zeek. * Update field docs (cherry picked from commit 7ad14e6)
* Added support for intel.log zeek module Enrich the #14150 supporting intel.log Co-Authored-By: Arcuri Davide <[email protected]> * Update fields.yml Co-Authored-By: Arcuri Davide <[email protected]> * intel.log example intel.log Co-Authored-By: Arcuri Davide <[email protected]> * added default_field: false added default_field: false Co-Authored-By: Arcuri Davide <[email protected]> * Generate expected zeek/intel output event * Add changelog entry * Update field docs * Misc improvements Expand dots in zeek.intel.seen Parse ts value without dropping millisecond value Add event.ingested timestamp Convert ingest node pipeline to YAML Save JSON message in event.original * Updates to zeek.intel.seen Expand dots of all seen.* fields Change name of zeek.intel.seen.fa_file to zeek.intel.seen.f as documented by Zeek. * Update field docs (cherry picked from commit 7ad14e6)
@@ -53,10 +53,29 @@ processors: | |||
to: "destination.packets" | |||
|
|||
- from: "zeek.connection.conn_state" | |||
to: "zeek.connection.state" | |||
|
|||
to: "zeek.connection.state.code" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is breaking change to the mapping. We need to call this out in the changelog and take action to not affect 7.x with this change. @alakahakai can you look into fixing the 7.x branch before the 7.6 branch gets created.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR #15169
Add 30+ filesets to Filebeat Zeek module. Thanks to @Xander33 for the original PR elastic#13683.
Took over PR #13683 and finish it up.
EDIT by @cwurm
These filesets have been added (in addition to the ones that were already present: connection, dns, http, files, ssl, notice):