Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a breaking change in Filebeat module Zeek connection fileset #15169

Merged
merged 4 commits into from
Dec 19, 2019
Merged

Fix a breaking change in Filebeat module Zeek connection fileset #15169

merged 4 commits into from
Dec 19, 2019

Conversation

alakahakai
Copy link

Fix a breaking change in Filebeat module Zeek connection fileset where the field mapping of "connection.state" was changed. Now it uses connection.state and connection.state_code, instead of connection.state.msg and connection.state.code.

@alakahakai alakahakai requested a review from a team as a code owner December 18, 2019 00:00
@alakahakai alakahakai mentioned this pull request Dec 18, 2019
Merged
andrewkroh
andrewkroh approved these changes Dec 19, 2019
View reviewed changes
Copy link
Member

@andrewkroh andrewkroh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrewkroh andrewkroh added the needs_backport PR is waiting to be backported to other branches. label Dec 19, 2019
@alakahakai alakahakai merged commit eb646c1 into elastic:master Dec 19, 2019
@alakahakai alakahakai mentioned this pull request Dec 19, 2019
Merged
@alakahakai alakahakai added v7.6.0 and removed needs_backport PR is waiting to be backported to other branches. labels Dec 19, 2019
alakahakai pushed a commit that referenced this pull request Dec 19, 2019
Fix a breaking change in Filebeat module Zeek connection fileset (#15169
0e56dfa 
) (#15219)

* Fix a breaking change in Filebeat module Zeek connection fileset where the field mapping was changed

(cherry picked from commit eb646c1)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewkroh andrewkroh andrewkroh approved these changes

Assignees
No one assigned
Labels
bug Filebeat Filebeat module review v7.6.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alakahakai @andrewkroh