Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update haproxy.asciidoc #16324

Merged
merged 1 commit into from
Feb 28, 2020
Merged

Update haproxy.asciidoc #16324

merged 1 commit into from
Feb 28, 2020

Conversation

maireanu
Copy link
Contributor

Update the documentation
Add username and password for auth on haproxu status page if needed

What does this PR do?

Why is it important?

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

@maireanu
Update haproxy.asciidoc
4dcad04 
Update the documentation
Add username and password for auth on haproxu status page if needed
@elasticmachine
Copy link
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

1 similar comment
@elasticmachine
Copy link
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@ph ph added docs needs_backport PR is waiting to be backported to other branches. labels Feb 28, 2020
ph
ph approved these changes Feb 28, 2020
View reviewed changes
Copy link
Contributor

@ph ph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ph ph merged commit a45f125 into elastic:master Feb 28, 2020
urso pushed a commit to urso/beats that referenced this pull request Feb 28, 2020
Revert "Update haproxy.asciidoc (elastic#16324)"
db2e453 
The PR did unfortunately break the build, because it was updating a
generated file. Reverting this for now.

This reverts commit a45f125.
@urso urso mentioned this pull request Feb 28, 2020
Merged
@dedemorton dedemorton mentioned this pull request Feb 29, 2020
Merged
urso pushed a commit that referenced this pull request Feb 29, 2020
Revert "Update haproxy.asciidoc (#16324)" (#16702)
eadcac8 
The PR did unfortunately break the build, because it was updating a
generated file. Reverting this for now.

This reverts commit a45f125.
@maireanu maireanu deleted the patch-2 branch March 2, 2020 11:33
@dedemorton dedemorton removed the needs_backport PR is waiting to be backported to other branches. label Mar 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ph ph ph approved these changes

Assignees
No one assigned
Labels
docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@maireanu @elasticmachine @ph @dedemorton