Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Add username and password to haproxy example #16703

Merged
merged 1 commit into from
Mar 3, 2020
Merged

[docs] Add username and password to haproxy example #16703

merged 1 commit into from
Mar 3, 2020

Conversation

dedemorton
Copy link
Contributor

@dedemorton dedemorton commented Feb 29, 2020 •
edited by andresrc
Loading

Replaces #16324

@dedemorton dedemorton added docs libbeat Team:Integrations Label for the Integrations team labels Feb 29, 2020
@dedemorton dedemorton requested a review from a team as a code owner February 29, 2020 00:16
@dedemorton dedemorton added the needs_backport PR is waiting to be backported to other branches. label Feb 29, 2020
@andresrc andresrc added [zube]: Inbox [zube]: In Review and removed needs_backport PR is waiting to be backported to other branches. [zube]: Inbox labels Mar 2, 2020
@dedemorton dedemorton requested a review from ph March 2, 2020 21:59
@dedemorton dedemorton merged commit d9f553d into elastic:master Mar 3, 2020
@dedemorton dedemorton deleted the replace_16324 branch March 3, 2020 19:32
@dedemorton dedemorton added the needs_backport PR is waiting to be backported to other branches. label Mar 3, 2020
@ycombinator ycombinator mentioned this pull request Mar 3, 2020
Merged
@ycombinator
Copy link
Contributor

Hey @dedemorton I think this PR is incomplete? I've created #16776 to complete the change started in this PR.

@ycombinator
Copy link
Contributor

Also, I see that there's a needs_backport label on this PR but it doesn't say which versions this PR will be going into. Could you please add the version labels so I can backport #16776 to the same version branches? Thanks!

@dedemorton
Copy link
Contributor Author

I think it was a timing issue because my branch had this change. Anyhow, I'm not sure which versions. I would assume 7.6 and 7.x? Does @ph know?

@ph
Copy link
Contributor

ph commented Mar 4, 2020

I believe it's 7.x and 7.6?

@ycombinator
Copy link
Contributor

Thanks @ph. I'll setup the backports for this PR and it's follow up: #16776.

This was referenced Mar 4, 2020
Merged
Merged
ycombinator added a commit that referenced this pull request Mar 5, 2020
@ycombinator @dedemorton
[7.6] [docs] Add username and password to haproxy example (#16703) (#…
d71063b 
…16801)

* [docs] Add username and password to haproxy example (#16703)

* Generate haproxy module docs (#16776)

Co-authored-by: DeDe Morton <[email protected]>
ycombinator added a commit that referenced this pull request Mar 6, 2020
@ycombinator @dedemorton
[7.x] [docs] Add username and password to haproxy example (#16703) (#…
c803833 
…16800)

* [docs] Add username and password to haproxy example (#16703)

* Generate haproxy module docs (#16776)

Co-authored-by: DeDe Morton <[email protected]>
@dedemorton dedemorton removed the needs_backport PR is waiting to be backported to other branches. label Mar 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtojek mtojek mtojek approved these changes

@ph ph ph approved these changes

Assignees
No one assigned
Labels
docs libbeat review Team:Integrations Label for the Integrations team v7.6.2 v7.7.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dedemorton @ycombinator @ph @mtojek @andresrc