Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing logger init in New() functions #16915

Merged
merged 5 commits into from
Mar 10, 2020
Merged

Add missing logger init in New() functions #16915

merged 5 commits into from
Mar 10, 2020

Conversation

kaiyan-sheng
Copy link
Contributor

This PR fixes #16886 by adding init loggers in New() functions.

@kaiyan-sheng kaiyan-sheng self-assigned this Mar 10, 2020
@kaiyan-sheng kaiyan-sheng added review Team:Platforms Label for the Integrations - Platforms team labels Mar 10, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations-platforms (Team:Platforms)

@ycombinator
Copy link
Contributor

You might want to think about the logger introduced in https://github.com/elastic/beats/pull/16886/files#diff-1ac599b7873eb92c72ababd1ba424851R37 as well. AFAICT it's never being initialized.

@ycombinator
Copy link
Contributor

Same (as previous comment) goes for the loggers introduced in other reader structs in https://github.com/elastic/beats/pull/16886/files. AFAICT those loggers are never initialized so the struct fields will start out as nils.

@kaiyan-sheng
Copy link
Contributor Author

kaiyan-sheng commented Mar 10, 2020 •
edited
Loading

@ycombinator Yep, just added those too. Thanks for checking!! I think it's all covered now 😂

ycombinator
ycombinator approved these changes Mar 10, 2020
View reviewed changes
Copy link
Contributor

@ycombinator ycombinator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. WFG.

@kaiyan-sheng
Copy link
Contributor Author

This will be backported with #16886.

@kaiyan-sheng kaiyan-sheng mentioned this pull request Mar 10, 2020
Closed
@kaiyan-sheng
Copy link
Contributor Author

CI failures are not related, merging this PR.

@kaiyan-sheng kaiyan-sheng merged commit e64a18f into elastic:master Mar 10, 2020
@kaiyan-sheng kaiyan-sheng deleted the fix_libbeat branch March 10, 2020 04:22
@kaiyan-sheng kaiyan-sheng mentioned this pull request Mar 11, 2020
Merged
kaiyan-sheng added a commit that referenced this pull request Mar 17, 2020
@kaiyan-sheng
Cherry-pick #16886 to 7.x: [Libbeat] Remove global logger from libbea…
02d3c70 
…t publisher and reader (#16912)

* Remove global logger from libbeat publisher and reader (#16886)


(cherry picked from commit ad2672d)

* backport #16915 in this PR
@kaiyan-sheng kaiyan-sheng mentioned this pull request Mar 18, 2020
Merged
kaiyan-sheng added a commit that referenced this pull request Mar 18, 2020
@kaiyan-sheng
Add missing logger init in New() functions (#16915) (#17087)
2cd1212 
* Add missing logger init in New() functions

(cherry picked from commit e64a18f)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ycombinator ycombinator ycombinator approved these changes

Assignees

@kaiyan-sheng kaiyan-sheng

Labels
review Team:Platforms Label for the Integrations - Platforms team v7.7.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kaiyan-sheng @elasticmachine @ycombinator