Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing logger init in New() functions #16915

Merged
merged 5 commits into from
Mar 10, 2020
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add logger init for readers
kaiyan-sheng committed Mar 10, 2020
commit 0d6fb38a32d182fdf6865ab93305dc018e098a2c
1 change: 1 addition & 0 deletions libbeat/reader/readfile/line.go
Original file line number Diff line number Diff line change
@@ -67,6 +67,7 @@ func NewLineReader(input io.Reader, config Config) (*LineReader, error) {
decodedNl: terminator,
inBuffer: streambuf.New(nil),
outBuffer: streambuf.New(nil),
logger: logp.NewLogger("readfile_line"),
ycombinator marked this conversation as resolved.
Show resolved Hide resolved
}, nil
}

1 change: 1 addition & 0 deletions libbeat/reader/readjson/docker_json.go
Original file line number Diff line number Diff line change
@@ -66,6 +66,7 @@ func New(r reader.Reader, stream string, partial bool, format string, CRIFlags b
partial: partial,
reader: r,
criflags: CRIFlags,
logger: logp.NewLogger("reader_docker_json"),
}

switch strings.ToLower(format) {
6 changes: 5 additions & 1 deletion libbeat/reader/readjson/json.go
Original file line number Diff line number Diff line change
@@ -39,7 +39,11 @@ type JSONReader struct {

// NewJSONReader creates a new reader that can decode JSON.
func NewJSONReader(r reader.Reader, cfg *Config) *JSONReader {
return &JSONReader{reader: r, cfg: cfg}
return &JSONReader{
reader: r,
cfg: cfg,
logger: logp.NewLogger("reader_json"),
}
}

// decodeJSON unmarshals the text parameter into a MapStr and