[Heartbeat][Docs] Consistently use id/name in all examples #17694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We should always include these optional config values, as not using them creates continuity issues in the Uptime app. The `id` attribute is the only way we can consistently identify a monitor over time when its config changes, and the `name` attribute is used for display purposes in the Uptime app. This change makes our docs examples reflect best practices.
andrewvc
added
docs
[zube]: In Review
Team:obs-ds-hosted-services
|
Pinging @elastic/uptime (:uptime) |
andrewvc
added a commit
to andrewvc/beats
that referenced
this pull request
Apr 14, 2020
…7694) We should always include these optional config values, as not using them creates continuity issues in the Uptime app. The `id` attribute is the only way we can consistently identify a monitor over time when its config changes, and the `name` attribute is used for display purposes in the Uptime app. This change makes our docs examples reflect best practices. (cherry picked from commit 4bb189d)
andrewvc
added a commit
to andrewvc/beats
that referenced
this pull request
Apr 14, 2020
…7694) We should always include these optional config values, as not using them creates continuity issues in the Uptime app. The `id` attribute is the only way we can consistently identify a monitor over time when its config changes, and the `name` attribute is used for display purposes in the Uptime app. This change makes our docs examples reflect best practices. (cherry picked from commit 4bb189d)
andrewvc
added a commit
that referenced
this pull request
Apr 15, 2020
…17698) We should always include these optional config values, as not using them creates continuity issues in the Uptime app. The `id` attribute is the only way we can consistently identify a monitor over time when its config changes, and the `name` attribute is used for display purposes in the Uptime app. This change makes our docs examples reflect best practices. (cherry picked from commit 4bb189d)
andrewvc
added a commit
that referenced
this pull request
Apr 15, 2020
…17697) We should always include these optional config values, as not using them creates continuity issues in the Uptime app. The `id` attribute is the only way we can consistently identify a monitor over time when its config changes, and the `name` attribute is used for display purposes in the Uptime app. This change makes our docs examples reflect best practices. (cherry picked from commit 4bb189d)
This was referenced Apr 22, 2020
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
…7694) (elastic#17698) We should always include these optional config values, as not using them creates continuity issues in the Uptime app. The `id` attribute is the only way we can consistently identify a monitor over time when its config changes, and the `name` attribute is used for display purposes in the Uptime app. This change makes our docs examples reflect best practices. (cherry picked from commit 59bf972)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should always include these optional config values, as not using them creates continuity issues in the Uptime app. The
idattribute is the only way we can consistently identify a monitor over time when its config changes, and thenameattribute is used for display purposes in the Uptime app.This change makes our docs examples reflect best practices.