[Heartbeat] Add id/name to all YML examples, fix geo defaults #17886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch fixes elastic#16460 by using the `id` and `name` fields in all our examples. Customers should always set these. The only reason we don't require them is backwards compat concerns with earlier 7.x heartbeats. This patch also fixes the indentation of the `add_observer_metadata` example in `heartbeat.yml`. Prior to this uncommenting it would not yield a valid config, due it being at the wrong indent level.
andrewvc
added
enhancement
Heartbeat
Team:obs-ds-hosted-services
|
Pinging @elastic/uptime (:uptime) |
blakerouse
approved these changes
Apr 22, 2020
Merged
4 tasks
andrewvc
added a commit
to andrewvc/beats
that referenced
this pull request
Apr 22, 2020
…c#17886) This patch fixes elastic#16460 by using the `id` and `name` fields in all our examples. Customers should always set these. The only reason we don't require them is backwards compat concerns with earlier 7.x heartbeats. This patch also fixes the indentation of the `add_observer_metadata` example in `heartbeat.yml`. Prior to this uncommenting it would not yield a valid config, due it being at the wrong indent level. (cherry picked from commit cdb20e2)
andrewvc
added a commit
that referenced
this pull request
Apr 22, 2020
#17896) This patch fixes #16460 by using the `id` and `name` fields in all our examples. Customers should always set these. The only reason we don't require them is backwards compat concerns with earlier 7.x heartbeats. This patch also fixes the indentation of the `add_observer_metadata` example in `heartbeat.yml`. Prior to this uncommenting it would not yield a valid config, due it being at the wrong indent level. (cherry picked from commit cdb20e2)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch fixes #16460 by using the
idandnamefields in all our examples. Customers should always set these. The only reason we don't require them is backwards compat concerns with earlier 7.x heartbeats.Frequently on the forum we find that people haven't set these options when they really should. We took one step forward in #17694 and this completes the story.
This patch also fixes the indentation of the
add_observer_metadataexample inheartbeat.yml. Prior to this uncommenting it would not yield a valid config, due it being at the wrong indent level.Checklist
- [ ] I have commented my code, particularly in hard-to-understand areas- [ ] I have made corresponding changes to the documentation- [ ] I have made corresponding change to the default configuration files- [ ] I have added tests that prove my fix is effective or that my feature works- [ ] I have added an entry inCHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.How to test this PR locally
heartbeat.ymlit should run without erroradd_observer_metadataoptions in heartbeat.yml, it should workdisabledfrom all configs inconfigs.dto run them, they should all work