Cherry-pick #17972 to 7.x: Fix filebeat script tester tests #18090
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The tester assumes pipelines have a JSON extension. So it started failing when the one of the pipelines was changed to YAML. I made changes to fix the test, but added an explicit error if you try to use this tool with a YAML pipeline. Additionally I noticed this tool does not handle templated pipelines. (cherry picked from commit 96f66a4)
botelastic
bot
added
the
needs_team
|
Pinging @elastic/siem (Team:SIEM) |
andrewkroh
approved these changes
Apr 29, 2020
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of PR #17972 to 7.x branch. Original message:
What does this PR do?
The tester assumes pipelines have a JSON extension. So it started failing when the
one of the pipelines was changed to YAML. I made changes to fix the test, but added
an explicit error if you try to use this tool with a YAML pipeline.
Additionally I noticed this tool does not handle templated pipelines.
Why is it important?
The tests are failing.