Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherry-pick #17978 to 7.x: Changing field type to keyword #18092

Merged
merged 2 commits into from
Apr 30, 2020
Merged

Cherry-pick #17978 to 7.x: Changing field type to keyword #18092

merged 2 commits into from
Apr 30, 2020

Conversation

kaiyan-sheng
Copy link
Contributor

@kaiyan-sheng kaiyan-sheng commented Apr 29, 2020 •
edited by zube bot
Loading

Cherry-pick of PR #17978 to 7.x branch. Original message:

  • Enhancement

What does this PR do?

Modify the field type from filebeat/nginx module fields from text to keyword as requested in #17834

Why is it important?

See Issue #17834

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

Note

First PR ever, go easy on me ;)

@SHolzhauer @kaiyan-sheng
Changing field type to keyword (#17978)
f6f0082 
* Changing field type to keyword
* Adding changelog

(cherry picked from commit 5cd6b52)
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Apr 29, 2020
@kaiyan-sheng kaiyan-sheng self-assigned this Apr 29, 2020
@elasticmachine
Copy link
Collaborator

elasticmachine commented Apr 29, 2020 •
edited
Loading

💔 Build Failed

Pipeline View Test View Changes Artifacts preview stats

Expand to view the summary

Build stats

Test stats 🧪

Test Results
Failed 5
Passed 1640
Skipped 126
Total 1771

Test errors

Expand to view the tests failures

  • Name: Build and Test / Filebeat Windows / TestLoadManifestNginx – fileset

    • Status: FAILED
    • Age: 1
    • Duration: 0.02
    • Error Details: Failed

  • Name: Build and Test / Filebeat Windows / TestGetInputConfigNginx – fileset

    • Status: FAILED
    • Age: 1
    • Duration: 0.02
    • Error Details: Failed

  • Name: Build and Test / Filebeat Windows / TestGetInputConfigNginxOverrides – fileset

    • Status: FAILED
    • Age: 1
    • Duration: 0.03
    • Error Details: Failed

  • Name: Build and Test / Filebeat Windows / TestGetInputConfigNginxOverrides/close_eof – fileset

    • Status: FAILED
    • Age: 1
    • Duration: 0.02
    • Error Details: Failed

  • Name: Build and Test / Filebeat Windows / TestGetPipelineNginx – fileset

    • Status: FAILED
    • Age: 1
    • Duration: 0.02
    • Error Details: Failed

Steps errors

Expand to view the steps failures

  • Name: Make -C filebeat testsuite

    • Description: make -C filebeat testsuite

    • Result: FAILURE

    • Duration: 4 min 40 sec<

    • Start Time: 2020-04-29T15:06:42.381+0000

  • Name: Mage build unitTest

    • Description: mage build unitTest

    • Result: FAILURE

    • Duration: 4 min 1 sec<

    • Start Time: 2020-04-29T15:11:02.136+0000

Log output

Expand to view the last 100 lines of log output 

[2020-04-29T15:29:50.279Z] [success] 0.54% test_xpack_modules.XPackTest.test_fileset_file_064_cisco: 2.2264s
[2020-04-29T15:29:50.279Z] [success] 0.54% test_xpack_modules.XPackTest.test_fileset_file_125_aws: 2.2244s
[2020-04-29T15:29:50.279Z] [success] 0.54% test_xpack_modules.XPackTest.test_fileset_file_059_ibmmq: 2.2120s
[2020-04-29T15:29:50.279Z] [success] 0.54% test_xpack_modules.XPackTest.test_fileset_file_121_aws: 2.2092s
[2020-04-29T15:29:50.279Z] [success] 0.54% test_xpack_modules.XPackTest.test_fileset_file_126_aws: 2.2081s
[2020-04-29T15:29:50.279Z] [success] 0.54% test_xpack_modules.XPackTest.test_fileset_file_132_aws: 2.2040s
[2020-04-29T15:29:50.279Z] [success] 0.54% test_xpack_modules.XPackTest.test_fileset_file_053_activemq: 2.2023s
[2020-04-29T15:29:50.279Z] [success] 0.54% test_xpack_modules.XPackTest.test_fileset_file_143_aws: 2.2023s
[2020-04-29T15:29:50.279Z] [success] 0.54% test_xpack_modules.XPackTest.test_fileset_file_133_aws: 2.2001s
[2020-04-29T15:29:50.279Z] [success] 0.54% test_xpack_modules.XPackTest.test_fileset_file_149_aws: 2.1998s
[2020-04-29T15:29:50.279Z] [success] 0.54% test_xpack_modules.XPackTest.test_fileset_file_145_aws: 2.1993s
[2020-04-29T15:29:50.279Z] [success] 0.53% test_xpack_modules.XPackTest.test_fileset_file_130_aws: 2.1976s
[2020-04-29T15:29:50.279Z] [success] 0.53% test_xpack_modules.XPackTest.test_fileset_file_054_activemq: 2.1959s
[2020-04-29T15:29:50.279Z] [success] 0.53% test_xpack_modules.XPackTest.test_fileset_file_112_aws: 2.1915s
[2020-04-29T15:29:50.279Z] [success] 0.53% test_xpack_modules.XPackTest.test_fileset_file_109_aws: 2.1902s
[2020-04-29T15:29:50.283Z] [success] 0.53% test_xpack_modules.XPackTest.test_fileset_file_129_aws: 2.1888s
[2020-04-29T15:29:50.283Z] [success] 0.53% test_xpack_modules.XPackTest.test_fileset_file_084_o365: 2.1833s
[2020-04-29T15:29:50.283Z] [success] 0.53% test_xpack_modules.XPackTest.test_fileset_file_105_aws: 2.1733s
[2020-04-29T15:29:50.283Z] [success] 0.53% test_xpack_modules.XPackTest.test_fileset_file_147_aws: 2.1703s
[2020-04-29T15:29:50.283Z] [success] 0.53% test_xpack_modules.XPackTest.test_fileset_file_017_zeek: 2.1688s
[2020-04-29T15:29:50.283Z] [success] 0.53% test_xpack_modules.XPackTest.test_fileset_file_141_aws: 2.1686s
[2020-04-29T15:29:50.283Z] [success] 0.53% test_xpack_modules.XPackTest.test_fileset_file_122_aws: 2.1686s
[2020-04-29T15:29:50.283Z] [success] 0.53% test_xpack_modules.XPackTest.test_fileset_file_113_aws: 2.1655s
[2020-04-29T15:29:50.283Z] [success] 0.52% test_xpack_modules.XPackTest.test_fileset_file_144_aws: 2.1487s
[2020-04-29T15:29:50.283Z] [success] 0.52% test_xpack_modules.XPackTest.test_fileset_file_115_aws: 2.1183s
[2020-04-29T15:29:50.283Z] [success] 0.51% test_xpack_modules.XPackTest.test_fileset_file_076_cisco: 2.1095s
[2020-04-29T15:29:50.283Z] [success] 0.51% test_xpack_modules.XPackTest.test_fileset_file_040_iptables: 2.1015s
[2020-04-29T15:29:50.283Z] [success] 0.51% test_xpack_modules.XPackTest.test_fileset_file_044_azure: 2.0791s
[2020-04-29T15:29:50.283Z] [success] 0.50% test_xpack_modules.XPackTest.test_fileset_file_063_cisco: 2.0730s
[2020-04-29T15:29:50.283Z] [success] 0.50% test_xpack_modules.XPackTest.test_fileset_file_002_envoyproxy: 2.0592s
[2020-04-29T15:29:50.283Z] [success] 0.50% test_xpack_modules.XPackTest.test_fileset_file_052_misp: 2.0542s
[2020-04-29T15:29:50.283Z] [success] 0.50% test_xpack_modules.XPackTest.test_fileset_file_027_zeek: 2.0411s
[2020-04-29T15:29:50.283Z] [success] 0.50% test_xpack_modules.XPackTest.test_fileset_file_062_cisco: 2.0391s
[2020-04-29T15:29:50.284Z] [success] 0.49% test_xpack_modules.XPackTest.test_fileset_file_004_zeek: 2.0332s
[2020-04-29T15:29:50.284Z] [success] 0.49% test_xpack_modules.XPackTest.test_fileset_file_065_cisco: 2.0239s
[2020-04-29T15:29:50.284Z] [success] 0.49% test_xpack_modules.XPackTest.test_fileset_file_043_iptables: 2.0178s
[2020-04-29T15:29:50.284Z] [success] 0.49% test_xpack_modules.XPackTest.test_fileset_file_006_zeek: 2.0174s
[2020-04-29T15:29:50.284Z] [success] 0.49% test_xpack_modules.XPackTest.test_fileset_file_042_iptables: 2.0152s
[2020-04-29T15:29:50.284Z] [success] 0.48% test_xpack_modules.XPackTest.test_fileset_file_016_zeek: 1.9800s
[2020-04-29T15:29:50.284Z] [success] 0.48% test_xpack_modules.XPackTest.test_fileset_file_020_zeek: 1.9715s
[2020-04-29T15:29:50.284Z] [success] 0.48% test_xpack_modules.XPackTest.test_fileset_file_011_zeek: 1.9685s
[2020-04-29T15:29:50.284Z] [success] 0.47% test_xpack_modules.XPackTest.test_fileset_file_018_zeek: 1.9504s
[2020-04-29T15:29:50.284Z] [success] 0.47% test_xpack_modules.XPackTest.test_fileset_file_034_zeek: 1.9407s
[2020-04-29T15:29:50.284Z] [success] 0.47% test_xpack_modules.XPackTest.test_fileset_file_033_zeek: 1.9400s
[2020-04-29T15:29:50.284Z] [success] 0.47% test_xpack_modules.XPackTest.test_fileset_file_036_zeek: 1.9399s
[2020-04-29T15:29:50.284Z] [success] 0.47% test_xpack_modules.XPackTest.test_fileset_file_007_zeek: 1.9369s
[2020-04-29T15:29:50.284Z] [success] 0.47% test_xpack_modules.XPackTest.test_fileset_file_013_zeek: 1.9198s
[2020-04-29T15:29:50.284Z] [success] 0.47% test_xpack_modules.XPackTest.test_fileset_file_019_zeek: 1.9154s
[2020-04-29T15:29:50.284Z] [success] 0.47% test_xpack_modules.XPackTest.test_fileset_file_009_zeek: 1.9138s
[2020-04-29T15:29:50.284Z] [success] 0.47% test_xpack_modules.XPackTest.test_fileset_file_012_zeek: 1.9131s
[2020-04-29T15:29:50.284Z] [success] 0.46% test_xpack_modules.XPackTest.test_fileset_file_029_zeek: 1.9096s
[2020-04-29T15:29:50.284Z] [success] 0.46% test_xpack_modules.XPackTest.test_fileset_file_026_zeek: 1.9047s
[2020-04-29T15:29:50.284Z] [success] 0.46% test_xpack_modules.XPackTest.test_fileset_file_024_zeek: 1.9017s
[2020-04-29T15:29:50.284Z] [success] 0.46% test_xpack_modules.XPackTest.test_fileset_file_005_zeek: 1.8850s
[2020-04-29T15:29:50.284Z] [success] 0.46% test_xpack_modules.XPackTest.test_fileset_file_031_zeek: 1.8699s
[2020-04-29T15:29:50.284Z] [success] 0.45% test_xpack_modules.XPackTest.test_fileset_file_015_zeek: 1.8635s
[2020-04-29T15:29:50.284Z] [success] 0.45% test_xpack_modules.XPackTest.test_fileset_file_038_zeek: 1.8624s
[2020-04-29T15:29:50.284Z] [success] 0.45% test_xpack_modules.XPackTest.test_fileset_file_028_zeek: 1.8609s
[2020-04-29T15:29:50.284Z] [success] 0.45% test_xpack_modules.XPackTest.test_fileset_file_014_zeek: 1.8580s
[2020-04-29T15:29:50.284Z] [success] 0.45% test_xpack_modules.XPackTest.test_fileset_file_022_zeek: 1.8454s
[2020-04-29T15:29:50.284Z] [success] 0.45% test_xpack_modules.XPackTest.test_fileset_file_023_zeek: 1.8450s
[2020-04-29T15:29:50.284Z] [success] 0.45% test_xpack_modules.XPackTest.test_fileset_file_008_zeek: 1.8433s
[2020-04-29T15:29:50.284Z] [success] 0.45% test_xpack_modules.XPackTest.test_fileset_file_037_zeek: 1.8373s
[2020-04-29T15:29:50.284Z] [success] 0.45% test_xpack_modules.XPackTest.test_fileset_file_010_zeek: 1.8314s
[2020-04-29T15:29:50.284Z] [success] 0.44% test_xpack_modules.XPackTest.test_fileset_file_025_zeek: 1.8209s
[2020-04-29T15:29:50.284Z] [success] 0.44% test_xpack_modules.XPackTest.test_fileset_file_032_zeek: 1.8087s
[2020-04-29T15:29:50.284Z] [success] 0.43% test_xpack_modules.XPackTest.test_fileset_file_035_zeek: 1.7848s
[2020-04-29T15:29:50.284Z] [success] 0.43% test_xpack_modules.XPackTest.test_fileset_file_030_zeek: 1.7754s
[2020-04-29T15:29:50.284Z] ----------------------------------------------------------------------
[2020-04-29T15:29:50.284Z] Ran 153 tests in 411.037s
[2020-04-29T15:29:50.284Z] 
[2020-04-29T15:29:50.284Z] OK
[2020-04-29T15:29:50.284Z] >> python test: Integration Testing Complete
[2020-04-29T15:29:50.284Z] >> Stopping Docker test environment...
[2020-04-29T15:30:03.456Z] Recording test results
[2020-04-29T15:30:16.102Z] Archiving artifacts
[2020-04-29T15:30:17.478Z] + curl -sSLo codecov https://codecov.io/bash
[2020-04-29T15:30:17.781Z] + FILE=auditbeat/build/coverage/full.cov
[2020-04-29T15:30:17.781Z] + [ -f auditbeat/build/coverage/full.cov ]
[2020-04-29T15:30:17.781Z] + FILE=filebeat/build/coverage/full.cov
[2020-04-29T15:30:17.781Z] + [ -f filebeat/build/coverage/full.cov ]
[2020-04-29T15:30:17.781Z] + FILE=heartbeat/build/coverage/full.cov
[2020-04-29T15:30:17.781Z] + [ -f heartbeat/build/coverage/full.cov ]
[2020-04-29T15:30:17.781Z] + FILE=libbeat/build/coverage/full.cov
[2020-04-29T15:30:17.781Z] + [ -f libbeat/build/coverage/full.cov ]
[2020-04-29T15:30:17.781Z] + FILE=metricbeat/build/coverage/full.cov
[2020-04-29T15:30:17.781Z] + [ -f metricbeat/build/coverage/full.cov ]
[2020-04-29T15:30:17.781Z] + FILE=packetbeat/build/coverage/full.cov
[2020-04-29T15:30:17.781Z] + [ -f packetbeat/build/coverage/full.cov ]
[2020-04-29T15:30:17.781Z] + FILE=winlogbeat/build/coverage/full.cov
[2020-04-29T15:30:17.781Z] + [ -f winlogbeat/build/coverage/full.cov ]
[2020-04-29T15:30:17.781Z] + FILE=journalbeat/build/coverage/full.cov
[2020-04-29T15:30:17.781Z] + [ -f journalbeat/build/coverage/full.cov ]
[2020-04-29T15:30:20.748Z] Running on Jenkins in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-18092
[2020-04-29T15:30:21.031Z] [INFO] getVaultSecret: Getting secrets
[2020-04-29T15:30:21.159Z] Masking supported pattern matches of $VAULT_ADDR or $VAULT_ROLE_ID or $VAULT_SECRET_ID
[2020-04-29T15:30:22.468Z] + chmod 755 generate-build-data.sh
[2020-04-29T15:30:22.468Z] + ./generate-build-data.sh https://beats-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/Beats/beats-beats-mbp/PR-18092/ https://beats-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/Beats/beats-beats-mbp/PR-18092/runs/2 FAILURE 3216072
[2020-04-29T15:30:23.050Z] INFO: curl https://beats-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/Beats/beats-beats-mbp/PR-18092/runs/2/steps/?limit=10000 -o steps-info.json
[2020-04-29T15:30:24.393Z] INFO: curl https://beats-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/Beats/beats-beats-mbp/PR-18092/runs/2/tests/?status=FAILED -o tests-errors.json

@kaiyan-sheng
Copy link
Contributor Author

CI failure is fixed in #18090

@kaiyan-sheng kaiyan-sheng merged commit 01e6d3c into elastic:7.x Apr 30, 2020
@kaiyan-sheng kaiyan-sheng deleted the backport_17978_7.x branch April 30, 2020 13:50
@andresrc andresrc removed the needs_team Indicates that the issue/PR needs a Team:* label label May 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChrsMark ChrsMark ChrsMark approved these changes

Assignees

@kaiyan-sheng kaiyan-sheng

Labels
backport review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kaiyan-sheng @elasticmachine @ChrsMark @andresrc @SHolzhauer