Skip config check in autodiscover for duplicated configurations #29048
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the configuration is already running, it has been already checked, don't try to check it again to avoid problems with configuration checks that fail if some resource already exist with the same identifiers.
jsoriano
added
Team:Integrations
|
Pinging @elastic/integrations (Team:Integrations) |
|
Pinging @elastic/uptime (Team:Uptime) |
botelastic
bot
added
needs_team
|
/package |
|
This pull request does not have a backport label. Could you fix it @jsoriano? 🙏
NOTE: |
mergify
bot
added
the
backport-skip
jsoriano
added
backport-v7.16.0
mergify
bot
removed
the
backport-skip
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
💚 Flaky test reportTests succeeded. 🤖 GitHub commentsTo re-run your PR in the CI, just comment with:
|
andrewvc
reviewed
Nov 19, 2021
…heck-config-not-used
6 tasks
|
Failure is unrelated, it looks related to the recent changes in beat module fields. |
ChrsMark
approved these changes
Nov 22, 2021
|
/package |
andrewvc
approved these changes
Nov 22, 2021
|
E2E failures may be related, I will check. |
|
E2E tests use the |
|
PR to address changes in the file output elastic/e2e-testing#1829 |
…heck-config-not-used
|
/package |
mergify bot
pushed a commit
that referenced
this pull request
Nov 24, 2021
If the configuration is already running, it has been already checked, don't try to check it again to avoid problems with configuration checks that fail if some resource already exist with the same identifiers. (cherry picked from commit 1207d63)
mergify bot
pushed a commit
that referenced
this pull request
Nov 24, 2021
If the configuration is already running, it has been already checked, don't try to check it again to avoid problems with configuration checks that fail if some resource already exist with the same identifiers. (cherry picked from commit 1207d63)
v1v
added a commit
to v1v/beats
that referenced
this pull request
Nov 24, 2021
…ws-on-file-changes * upstream/master: override host on statsd metricset (elastic#29103) Skip config check in autodiscover for duplicated configurations (elastic#29048) Change "filebeat.config.modules.enabled" to "true" (elastic#28769) Remove deprecated spool queue from Beats (elastic#28869) Add `beat` field back to beat.stats (elastic#29094) Revert "Move labels and annotations under kubernetes.namespace. (elastic#27917)" (elastic#29069) heartbeat: remove w2008 in the CI (elastic#29093) Remove deprecated `--template` and `--index-policy` flags (elastic#28870) Fix parsing of apache trace log levels (elastic#28717) [Elastic-Agent] IUse itnernal port for local fleet server (elastic#28993) [Heartbeat] Log error on dupe monitor ID instead of strict req (elastic#29041) Enable pprof for elastic-agent and beats (elastic#28983)
jsoriano
added a commit
that referenced
this pull request
Nov 24, 2021
…) (#29119) If the configuration is already running, it has been already checked, don't try to check it again to avoid problems with configuration checks that fail if some resource already exist with the same identifiers. (cherry picked from commit 1207d63) Co-authored-by: Jaime Soriano Pastor <[email protected]>
jsoriano
added a commit
that referenced
this pull request
Nov 24, 2021
…) (#29118) If the configuration is already running, it has been already checked, don't try to check it again to avoid problems with configuration checks that fail if some resource already exist with the same identifiers. (cherry picked from commit 1207d63) Co-authored-by: Jaime Soriano Pastor <[email protected]>
v1v
added a commit
to v1v/beats
that referenced
this pull request
Nov 30, 2021
* upstream/master: (577 commits) Remove Journalbeat (elastic#29131) Add note that there is no warranty or support for generator code (elastic#28797) packetbeat: preparation for npcap addition (elastic#29017) Use the generic helper for opening file to read in filestream (elastic#29180) Workflow for macos (elastic#29174) Fix `decode_json_fields` processor to always add error key (elastic#29107) Workflow for macos (elastic#29156) Fix agent download timeout values in yaml files (elastic#29039) Added workflow file for builds with macos (elastic#29148) CI: enable AWS cloud testing on a PR basis if changes in certain files (elastic#29047) Remove links to Journalbeat (elastic#29134) Fix rds metadata in cloudwatch metricset (elastic#29106) [mergify]: notify conflicts in PRs that are still open (elastic#29122) Use NamedWatcher in Agent's k8s provider (elastic#29095) override host on statsd metricset (elastic#29103) Skip config check in autodiscover for duplicated configurations (elastic#29048) Change "filebeat.config.modules.enabled" to "true" (elastic#28769) Remove deprecated spool queue from Beats (elastic#28869) Add `beat` field back to beat.stats (elastic#29094) Revert "Move labels and annotations under kubernetes.namespace. (elastic#27917)" (elastic#29069) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Skips configuration checks for configurations that are already running,
and were then already checked.
Why is it important?
If the configuration is already running, it has been already checked,
don't try to check it again to avoid problems with configuration checks
that fail if some resource already exist with the same identifiers.
Checklist
CHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Author's Checklist
How to test this PR locally
Related issues
Use cases
Heartbeat configurations cannot have the same ID, this is checked already in
CheckConfig. On these case, if there is a configuration already running, autodiscover shouldn't need to check the config again, that is going to fail.Screenshots
Logs