-
Notifications
You must be signed in to change notification settings - Fork 42
Get output files when they have a suffix #1829
Get output files when they have a suffix #1829
Conversation
This pull request does not have a backport label. Could you fix it @jsoriano? 🙏
|
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
💚 Flaky test reportTests succeeded. 🤖 GitHub commentsTo re-run your PR in the CI, just comment with:
|
ad43274
to
59b38cd
Compare
Opening for review. If this continues giving problems, maybe it is better to setup Elasticsearch and use this output, as is already done for elastic-agent scenarios. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for tuning the tests! lgtm if CI is happy :)!
(cherry picked from commit dd51a90)
(cherry picked from commit dd51a90) Co-authored-by: Jaime Soriano Pastor <[email protected]>
What does this PR do?
Since elastic/beats#28927, Beats file output appends a suffix to all files, that can be also rotated.
This PR makes the following changes to address this issue:
Why is it important?
To fix autodiscover tests.
Checklist
make unit-test
), and they are passing locallymake notice
in the proper directory)Author's Checklist
How to test this PR locally
Related issues
logging.files.suffix
option and always use datetime suffixes beats#28927.