Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x-pack/filebeat/input/cel: provide XML decoding functionality #35372

Merged
merged 1 commit into from
May 31, 2023
Merged

x-pack/filebeat/input/cel: provide XML decoding functionality #35372

merged 1 commit into from
May 31, 2023

Conversation

efd6
Copy link
Contributor

@efd6 efd6 commented May 8, 2023

What does this PR do?

This addition makes use of the mito XML library to allow users to decode XML responses with type hints.

Also clean up some CEL input documentation.

Why is it important?

This is a blocker for an integration.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

@efd6 efd6 added enhancement Filebeat Filebeat Team:Security-External Integrations backport-skip Skip notification from the automated backport with mergify 8.9-candidate labels May 8, 2023
@efd6 efd6 self-assigned this May 8, 2023
@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels May 8, 2023
@elasticmachine
Copy link
Collaborator

elasticmachine commented May 8, 2023 •
edited by jenkins-beats-ci bot
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-05-26T08:01:13.778+0000

  • Duration: 72 min 27 sec

Test stats 🧪

Test Results
Failed 0
Passed 2910
Skipped 175
Total 3085

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@efd6
Copy link
Contributor Author

efd6 commented May 8, 2023

/test

@efd6 efd6 changed the title x-pack/filebeat/input/httpjson: provide XML decoding functionality x-pack/filebeat/input/cel: provide XML decoding functionality May 9, 2023
@mergify

This comment was marked as outdated.

Sign in to view
@mergify

This comment was marked as outdated.

Sign in to view
@efd6 efd6 force-pushed the 34438-cel branch 2 times, most recently from d6d2bd6 to 6643b3c Compare May 12, 2023 10:29
@mergify

This comment was marked as outdated.

Sign in to view
@efd6 efd6 marked this pull request as ready for review May 19, 2023 01:57
@efd6 efd6 requested a review from a team as a code owner May 19, 2023 01:57
@elasticmachine
Copy link
Collaborator

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@efd6 efd6 mentioned this pull request May 24, 2023
Merged
6 tasks
@mergify

This comment was marked as outdated.

Sign in to view
@efd6
x-pack/filebeat/input/cel: provide XML decoding functionality
4573eb5 
Note a minor difference between the outcome of HTTPJSON XML parsing and
CEL XML parsing arrises due to the final result from CEL being passed
back to the input via JSON. This has the effect that numbers are coerced
to float, despite being type-hinted as integer. This should have minimal
impact, but it is important to be aware of during ingest.
ShourieG
ShourieG approved these changes May 31, 2023
View reviewed changes
Copy link
Contributor

@ShourieG ShourieG left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, is there anything we can do to make the linter happy ?

@efd6
Copy link
Contributor Author

efd6 commented May 31, 2023

The linter is broken and should not be used.

@efd6 efd6 merged commit c1fa439 into elastic:main May 31, 2023
chrisberkhout pushed a commit that referenced this pull request Jun 1, 2023
@efd6 @chrisberkhout
x-pack/filebeat/input/cel: provide XML decoding functionality (#35372)
2b69239 
Note a minor difference between the outcome of HTTPJSON XML parsing and
CEL XML parsing arrises due to the final result from CEL being passed
back to the input via JSON. This has the effect that numbers are coerced
to float, despite being type-hinted as integer. This should have minimal
impact, but it is important to be aware of during ingest.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShourieG ShourieG ShourieG approved these changes

Assignees

@efd6 efd6

Labels
8.9-candidate backport-skip Skip notification from the automated backport with mergify enhancement Filebeat Filebeat
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@efd6 @elasticmachine @ShourieG