Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x-pack/filebeat/input/cel: mark as GA #35559

Merged
merged 1 commit into from
May 31, 2023
Merged

x-pack/filebeat/input/cel: mark as GA #35559

merged 1 commit into from
May 31, 2023

Conversation

efd6
Copy link
Contributor

@efd6 efd6 commented May 24, 2023

What does this PR do?

Marks the CEL input as GA.

Why is it important?

Milestone plan item.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

@efd6 efd6 added enhancement Filebeat Filebeat backport-skip Skip notification from the automated backport with mergify 8.9-candidate labels May 24, 2023
@efd6 efd6 self-assigned this May 24, 2023
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label May 24, 2023
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label May 24, 2023
@elasticmachine
Copy link
Collaborator

elasticmachine commented May 24, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-05-31T10:44:04.647+0000

  • Duration: 75 min 12 sec

Test stats 🧪

Test Results
Failed 0
Passed 2922
Skipped 175
Total 3097

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@efd6 efd6 marked this pull request as ready for review May 24, 2023 21:15
@efd6 efd6 requested a review from a team as a code owner May 24, 2023 21:15
@elasticmachine
Copy link
Collaborator

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

Copy link
Contributor

@taylor-swanson taylor-swanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just need to make the linter happy.

@efd6
Copy link
Contributor Author

efd6 commented May 31, 2023

The linter cannot be made happy here; it is incorrect, and worse, the specific linter (typecheck) should not exist since it is just repeating work done by go tool compile. That is, if the linter were correct the compilation would fail.

The complaint here is that rest is not used, but clearly is in the case body in the switch at the bottom of this snippet.

	key, rest, more := strings.Cut(path, ".")
	v, ok := m[key]
	if !ok {
		return
	}
	if !more {
		fn(m, key)
		return
	}
	switch v := v.(type) {
	case mapstr.M:
		walkMap(v, rest, fn)

Locally, golangci-lint does not complain about this, but the action does. I believe that this is related to golangci/golangci-lint-action#624 which has gained no traction. golangci-lint does not allow this redundant and broken linter to be turned off.

@efd6 efd6 merged commit b45d1da into elastic:main May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.9-candidate backport-skip Skip notification from the automated backport with mergify enhancement Filebeat Filebeat
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants