Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Postmigration setenv.sh && common.sh cleanup #39930

Merged
merged 17 commits into from
Jul 12, 2024

Conversation

oakrizan
Copy link
Contributor

@oakrizan oakrizan commented Jun 18, 2024

Proposed commit message

After migration setenv.sh is not needed anymore, since all env vars are defined in related scripts or pipelines.
Added GOX_FLAGS for all steps, as it was in Jenkins.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

Logs

BK builds: https://buildkite.com/elastic/beats/builds?branch=oakrizan%3Apostmigration-setenv-cleanup

@oakrizan oakrizan added :Windows ci :integrations macOS Enable builds in the CI for darwin testing arm Enable builds in the CI for ARM testing aws Enable builds in the CI for aws cloud testing Team:Ingest-EngProd backport-v8.14.0 Automated backport with mergify labels Jun 18, 2024
@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Jun 18, 2024
@oakrizan oakrizan force-pushed the postmigration-setenv-cleanup branch 2 times, most recently from f82c380 to 20e612b Compare June 18, 2024 12:19
Copy link
Contributor

mergify bot commented Jun 19, 2024

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b postmigration-setenv-cleanup upstream/postmigration-setenv-cleanup
git merge upstream/main
git push upstream postmigration-setenv-cleanup

@oakrizan oakrizan force-pushed the postmigration-setenv-cleanup branch from 1442eb8 to 4f487f2 Compare June 20, 2024 07:57
Copy link
Contributor

mergify bot commented Jun 20, 2024

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b postmigration-setenv-cleanup upstream/postmigration-setenv-cleanup
git merge upstream/main
git push upstream postmigration-setenv-cleanup

@oakrizan oakrizan force-pushed the postmigration-setenv-cleanup branch 4 times, most recently from 735b2bf to 8727678 Compare June 27, 2024 12:22
Copy link
Contributor

mergify bot commented Jul 1, 2024

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b postmigration-setenv-cleanup upstream/postmigration-setenv-cleanup
git merge upstream/main
git push upstream postmigration-setenv-cleanup

@oakrizan oakrizan force-pushed the postmigration-setenv-cleanup branch 7 times, most recently from a2afc64 to 8546a5b Compare July 3, 2024 14:34
@oakrizan oakrizan marked this pull request as ready for review July 8, 2024 12:46
@oakrizan oakrizan requested a review from a team as a code owner July 8, 2024 12:46
@oakrizan oakrizan added the kubernetes Enable builds in the CI for kubernetes label Jul 9, 2024
@oakrizan
Copy link
Contributor Author

oakrizan commented Jul 9, 2024

/test

@oakrizan oakrizan added the backport-8.15 Automated backport to the 8.15 branch with mergify label Jul 9, 2024
@oakrizan
Copy link
Contributor Author

/test

@oakrizan oakrizan changed the title Postmigration setenv cleanup Postmigration setenv.sh && common.sh cleanup Jul 10, 2024
Copy link
Contributor

@dliappis dliappis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great to see so much old cruft getting removed!

LGTM provided that CI is green. Left a minor suggestion but it doesn't require another review cycle.

.buildkite/hooks/pre-command Outdated Show resolved Hide resolved
@oakrizan oakrizan merged commit 1f1e87e into elastic:main Jul 12, 2024
196 checks passed
mergify bot pushed a commit that referenced this pull request Jul 12, 2024
postmigration setenv.sh && common.sh cleanup

(cherry picked from commit 1f1e87e)
mergify bot pushed a commit that referenced this pull request Jul 12, 2024
postmigration setenv.sh && common.sh cleanup

(cherry picked from commit 1f1e87e)
oakrizan added a commit that referenced this pull request Jul 12, 2024
postmigration setenv.sh && common.sh cleanup

(cherry picked from commit 1f1e87e)

Co-authored-by: Olga Naydyonock <[email protected]>
oakrizan added a commit that referenced this pull request Jul 12, 2024
postmigration setenv.sh && common.sh cleanup

(cherry picked from commit 1f1e87e)

Co-authored-by: Olga Naydyonock <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arm Enable builds in the CI for ARM testing aws Enable builds in the CI for aws cloud testing backport-8.15 Automated backport to the 8.15 branch with mergify backport-v8.14.0 Automated backport with mergify ci :integrations kubernetes Enable builds in the CI for kubernetes macOS Enable builds in the CI for darwin testing Team:Ingest-EngProd :Windows
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants