-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Postmigration setenv.sh && common.sh cleanup #39930
Postmigration setenv.sh && common.sh cleanup #39930
Conversation
f82c380
to
20e612b
Compare
This pull request is now in conflicts. Could you fix it? 🙏
|
1442eb8
to
4f487f2
Compare
This pull request is now in conflicts. Could you fix it? 🙏
|
735b2bf
to
8727678
Compare
This pull request is now in conflicts. Could you fix it? 🙏
|
a2afc64
to
8546a5b
Compare
/test |
/test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great to see so much old cruft getting removed!
LGTM provided that CI is green. Left a minor suggestion but it doesn't require another review cycle.
postmigration setenv.sh && common.sh cleanup (cherry picked from commit 1f1e87e)
postmigration setenv.sh && common.sh cleanup (cherry picked from commit 1f1e87e)
postmigration setenv.sh && common.sh cleanup (cherry picked from commit 1f1e87e) Co-authored-by: Olga Naydyonock <[email protected]>
postmigration setenv.sh && common.sh cleanup (cherry picked from commit 1f1e87e) Co-authored-by: Olga Naydyonock <[email protected]>
Proposed commit message
After migration setenv.sh is not needed anymore, since all env vars are defined in related scripts or pipelines.
Added GOX_FLAGS for all steps, as it was in Jenkins.
Checklist
CHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.Related issues
Logs
BK builds: https://buildkite.com/elastic/beats/builds?branch=oakrizan%3Apostmigration-setenv-cleanup