Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[8.15](backport #39930) Postmigration setenv.sh && common.sh cleanup #40210

Merged
merged 1 commit into from
Jul 12, 2024
Merged

[8.15](backport #39930) Postmigration setenv.sh && common.sh cleanup #40210

merged 1 commit into from
Jul 12, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Jul 12, 2024 •
edited by zube bot
Loading

Proposed commit message

After migration setenv.sh is not needed anymore, since all env vars are defined in related scripts or pipelines.
Added GOX_FLAGS for all steps, as it was in Jenkins.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

Logs

BK builds: https://buildkite.com/elastic/beats/builds?branch=elastic%3Amergify%2Fbp%2F8.15%2Fpr-39930

This is an automatic backport of pull request #39930 done by [Mergify](https://mergify.com).

@oakrizan @mergify
Postmigration setenv.sh && common.sh cleanup (#39930)
79b6756 
postmigration setenv.sh && common.sh cleanup

(cherry picked from commit 1f1e87e)
@mergify mergify bot requested a review from a team as a code owner July 12, 2024 06:21
@mergify mergify bot added the backport label Jul 12, 2024
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Jul 12, 2024
@oakrizan oakrizan added :Windows ci :integrations macOS Enable builds in the CI for darwin testing arm Enable builds in the CI for ARM testing kubernetes Enable builds in the CI for kubernetes aws Enable builds in the CI for aws cloud testing Team:Ingest-EngProd labels Jul 12, 2024
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Jul 12, 2024
@oakrizan
Copy link
Contributor

/test

oakrizan
oakrizan approved these changes Jul 12, 2024
View reviewed changes
Copy link
Contributor

@oakrizan oakrizan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clean BP

@oakrizan oakrizan merged commit aa5ec88 into 8.15 Jul 12, 2024
196 checks passed
@oakrizan oakrizan deleted the mergify/bp/8.15/pr-39930 branch July 12, 2024 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oakrizan oakrizan oakrizan approved these changes

Assignees

@oakrizan oakrizan

Labels
arm Enable builds in the CI for ARM testing aws Enable builds in the CI for aws cloud testing backport ci :integrations kubernetes Enable builds in the CI for kubernetes macOS Enable builds in the CI for darwin testing Team:Ingest-EngProd :Windows
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@oakrizan