[8.14](backport #40467) x-pack/metricbeat/module/gcp: Fix missing ECS labels when using exclude_labels: true #40595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
botelastic
bot
added
the
needs_team
|
This pull request doesn't have a |
andrewkroh
reviewed
Aug 23, 2024
|
This pull request has not been merged yet. Could you please review and merge it @Linu-Elias? 🙏 |
Co-authored-by: Andrew Kroh <[email protected]>
|
This pull request has not been merged yet. Could you please review and merge it @Linu-Elias? 🙏 |
1 similar comment
|
This pull request has not been merged yet. Could you please review and merge it @Linu-Elias? 🙏 |
gpop63
approved these changes
Sep 9, 2024
shmsr
approved these changes
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed commit message
The GCP
metricsmetricset'sexclude_labels: trueoption causes an issue in thegroupTimeSeriesfunction. The default metadata collector is created as a value, preventing the function from initializingmetadataServicewith the correct time series data. This results in missing important labels likecloud.instance.idin the events. To fix this,metadataServiceshould be initially set to nil, allowing initialization based on the time series parameter.Checklist
CHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Disruptive User Impact
Author's Checklist
How to test this PR locally
Related issues
exclude_labels: true#40437Use cases
Screenshots
Compute Service Before Fix:
{ "_index": ".ds-metricbeat-8.16.0-2024.08.12-000001", "_id": "zWdtRpEBVgxWUufvh8Eh", "_version": 1, "_score": 0, "_source": { "@timestamp": "2024-08-12T11:46:00.000Z", "metricset": { "name": "compute", "period": 60000 }, "gcp": { "labels": {}, "compute": { "instance": { "uptime_total": { "sec": 965207 }, "memory": { "balloon": { "ram_size": { "value": 4115619840 }, "swap_in": { "bytes": 0 }, "swap_out": { "bytes": 0 }, "ram_used": { "value": 1657262080 } } }, "uptime": { "sec": 60.000000000116415 }, "cpu": { "usage": { "pct": 0.11856303568638395 }, "usage_time": { "sec": 7.113782141183037 } }, "network": { "egress": { "packets": { "count": 1217 }, "bytes": 883471 }, "ingress": { "packets": { "count": 980 }, "bytes": 230375 } }, "disk": { "read": { "bytes": 0 }, "write_ops_count": { "value": 1230 }, "read_ops_count": { "value": 0 }, "write": { "bytes": 12386800 } } } } }, "service": { "type": "gcp" }, "agent": { "name": "EPINPUNW06A8", "type": "metricbeat", "version": "8.16.0", "ephemeral_id": "6882ed99-deee-4fae-a6ee-af617960c5ea", "id": "f49fbc8d-cc6a-4629-89b1-454f33f48d82" }, "ecs": { "version": "8.0.0" }, "host": {}, "event": { "duration": 684338677, "dataset": "gcp.compute", "module": "gcp" } } }Compute Service After fix:
{ "_index": ".ds-metricbeat-8.16.0-2024.08.12-000001", "_id": "uGc7RpEBVgxWUufvzb4e", "_version": 1, "_score": 0, "_source": { "@timestamp": "2024-08-12T10:52:00.000Z", "metricset": { "name": "compute", "period": 60000 }, "gcp": { "labels": {}, "compute": { "instance": { "uptime_total": { "sec": 1980 }, "cpu": { "usage_time": { "sec": 0.13933221539459595 }, "usage": { "pct": 0.011611017949549662 } }, "uptime": { "sec": 60 } } } }, "service": { "type": "gcp" }, "cloud": { "region": "us-central1", "instance": { "id": "8449630262774775859" }, "account": { "id": "elastic-obs-integrations-dev", "name": "elastic-obs-integrations-dev" }, "provider": "gcp", "availability_zone": "us-central1-a" }, "host": {}, "ecs": { "version": "8.0.0" }, "agent": { "ephemeral_id": "c1f3c9a5-ff55-4d65-a586-e751805d1347", "id": "f49fbc8d-cc6a-4629-89b1-454f33f48d82", "name": "EPINPUNW06A8", "type": "metricbeat", "version": "8.16.0" }, "event": { "duration": 706928630, "dataset": "gcp.compute", "module": "gcp" } } }Spanner Service Before Fix:
{ "_index": ".ds-metricbeat-8.16.0-2024.08.12-000001", "_id": "CTKeRpEBGeZDOp8bEh6T", "_version": 1, "_score": 0, "_source": { "@timestamp": "2024-08-12T12:40:46.200Z", "event": { "duration": 921850497, "dataset": "gcp.metrics", "module": "gcp" }, "metricset": { "name": "metrics", "period": 60000 }, "gcp": { "metrics": { "instance": { "leader_percentage_by_region": { "value": 1 } } }, "labels": {} }, "service": { "type": "gcp" }, "ecs": { "version": "8.0.0" }, "host": {}, "agent": { "type": "metricbeat", "version": "8.16.0", "ephemeral_id": "4227a7c2-941d-45b0-ab3d-0328c7a3ee97", "id": "f49fbc8d-cc6a-4629-89b1-454f33f48d82", "name": "EPINPUNW06A8" } } }Spanner Service After Fix:
{ "_index": ".ds-metricbeat-8.16.0-2024.08.12-000001", "_id": "fDK1RpEBGeZDOp8bDx-J", "_version": 1, "_score": 0, "_source": { "@timestamp": "2024-08-12T13:06:00.000Z", "host": {}, "agent": { "ephemeral_id": "00deca2b-9a95-42af-809c-730759f69cdf", "id": "f49fbc8d-cc6a-4629-89b1-454f33f48d82", "name": "EPINPUNW06A8", "type": "metricbeat", "version": "8.16.0" }, "ecs": { "version": "8.0.0" }, "cloud": { "provider": "gcp", "instance": { "id": "spanner-1" }, "account": { "id": "elastic-obs-integrations-dev", "name": "elastic-obs-integrations-dev" } }, "event": { "dataset": "gcp.metrics", "module": "gcp", "duration": 955200812 }, "metricset": { "name": "metrics", "period": 60000 }, "gcp": { "metrics": { "instance": { "cpu": { "utilization_by_operation_type": { "value": 0 } } } }, "labels": { "metrics": { "priority": "medium", "database": "db-1", "category": "misc", "is_system": "false" }, "resource": { "instance_config": "regional-europe-west1", "location": "europe-west1" } } }, "service": { "type": "gcp" } } }This is an automatic backport of pull request #40467 done by [Mergify](https://mergify.com).