Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.14](backport #40467) x-pack/metricbeat/module/gcp: Fix missing ECS labels when using exclude_labels: true #40595

Merged
merged 2 commits into from
Sep 9, 2024
Merged

[8.14](backport #40467) x-pack/metricbeat/module/gcp: Fix missing ECS labels when using exclude_labels: true #40595

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c95524c
x-pack/metricbeat/module/gcp: Fix missing ECS labels when using exclu…
Linu-Elias Aug 23, 2024
0093353
Update CHANGELOG.next.asciidoc
Linu-Elias Aug 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.next.asciidoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,6 +99,7 @@ https://github.com/elastic/beats/compare/v8.8.1\...main[Check the HEAD diff]
- Fix missing metrics from CloudWatch when include_linked_accounts set to false. {issue}40071[40071] {pull}40135[40135]
- Update beat module with apm-server monitoring metrics fields {pull}40127[40127]
- Fix Azure Monitor metric timespan to restore Storage Account PT1H metrics {issue}40376[40376] {pull}40367[40367]
- Add missing ECS Cloud fields in GCP `metrics` metricset when using `exclude_labels: true` {issue}40437[40437] {pull}40467[40467]

*Osquerybeat*

Expand Down
2 changes: 1 addition & 1 deletion x-pack/metricbeat/module/gcp/metrics/metricset.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,7 +212,7 @@ func (m *MetricSet) Fetch(ctx context.Context, reporter mb.ReporterV2) (err erro
func (m *MetricSet) mapToEvents(ctx context.Context, timeSeries []timeSeriesWithAligner, sdc metricsConfig) ([]mb.Event, error) {
mapper := newIncomingFieldMapper(m.Logger(), sdc)

var metadataService = gcp.NewStackdriverMetadataServiceForTimeSeries(nil)
var metadataService gcp.MetadataService
var err error

if !m.config.ExcludeLabels {
Expand Down
Loading