[meraki] Log getDevicePerformanceScores errors
#41622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
botelastic
bot
added
the
needs_team
gpop63
added
bugfix
Team:Obs-InfraObs
botelastic
bot
removed
the
needs_team
|
This pull request does not have a backport label.
To fixup this pull request, you need to add the backport labels for the needed
|
|
|
mergify
bot
added
the
backport-8.x
tommyers-elastic
approved these changes
Nov 13, 2024
Co-authored-by: Tom Myers <[email protected]>
pierrehilbert
added
the
Team:Elastic-Agent-Data-Plane
|
Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane) |
Co-authored-by: Vihas Makwana <[email protected]>
VihasMakwana
approved these changes
Nov 14, 2024
mergify bot
pushed a commit
that referenced
this pull request
Nov 18, 2024
* log getDevicePerformanceScores errors * add changelog entry * fix PR id * Update x-pack/metricbeat/module/meraki/device_health/devices.go Co-authored-by: Tom Myers <[email protected]> * Update x-pack/metricbeat/module/meraki/device_health/devices.go Co-authored-by: Vihas Makwana <[email protected]> * fix imports --------- Co-authored-by: Tom Myers <[email protected]> Co-authored-by: Vihas Makwana <[email protected]> (cherry picked from commit f35602f)
6 tasks
gpop63
added a commit
that referenced
this pull request
Nov 18, 2024
…rs (#41659) * [meraki] Log `getDevicePerformanceScores` errors (#41622) * log getDevicePerformanceScores errors * add changelog entry * fix PR id * Update x-pack/metricbeat/module/meraki/device_health/devices.go Co-authored-by: Tom Myers <[email protected]> * Update x-pack/metricbeat/module/meraki/device_health/devices.go Co-authored-by: Vihas Makwana <[email protected]> * fix imports --------- Co-authored-by: Tom Myers <[email protected]> Co-authored-by: Vihas Makwana <[email protected]> (cherry picked from commit f35602f) * Update CHANGELOG.next.asciidoc --------- Co-authored-by: Gabriel Pop <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Currently,
getDevicePerformanceScoresstops the entire metric collection if it encounters an error for a single device that does not support this feature, impacting data collection for other devices. The function should log the errors and skip models with issues, ensuring that metric collection continues smoothly.Checklist
CHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Disruptive User Impact
Author's Checklist
How to test this PR locally
Related issues
getDevicePerformanceScoreserrors without stopping metric collection #41611Use cases
Screenshots
Logs