Beats preference pane for macOS #6923
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Part of #6053 |
andrewkroh
reviewed
Apr 30, 2018
| <dict> | ||
| <key>FILEHEADER</key> | ||
| <string><
There was a problem hiding this comment.
We have changed our header style a bit. You might be able to use elastic/go-licenser to apply the changes. If not you can grab the header from its golden testdata.
|
I think it would look nice to capitalize the product name used in "tab" labels. |
This preference pane shows up in System Preferences and allows to manage installed beats.
Added a make target to generate a package (.pkg) file that can be installed or bundled along another installer. It can be optionally signed for distribution.
Added new Elastic license boilerplate plus some missing headers.
Makes build to work when no internal developer certificate has been created in XCode.
adriansr
force-pushed
the
feature/osx-pref-pane
branch
from
99b27e7 to
c2b485a
Compare
|
pinging @mattapperson for a review From your original (pre-PR) review, you suggested a couple of changes:
However, after discussing it in our security area meeting it was decided to have an initial version asap and leave 1 and 2 for future improvements. WDYT? |
|
@adriansr I would say I am fine with that, though WWDC might force a quick turn around on 2 in a few days :) |
mattapperson
approved these changes
May 30, 2018
andrewkroh
approved these changes
May 31, 2018
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This preference pane shows up in System Preferences and allows to manage installed beats.
Only works with Beats installed with packages from #6344