Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix quotation in environment variables of systemd unit #9564

Merged
merged 1 commit into from
Dec 14, 2018
Merged

Fix quotation in environment variables of systemd unit #9564

merged 1 commit into from
Dec 14, 2018

Conversation

jsoriano
Copy link
Member

Fix #9562

@jsoriano jsoriano requested a review from a team as a code owner December 14, 2018 16:51
tsg
tsg approved these changes Dec 14, 2018
View reviewed changes
Copy link
Contributor

@tsg tsg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@graphaelli
Copy link
Member

nice find @jsoriano

@jsoriano jsoriano self-assigned this Dec 14, 2018
andrewkroh
andrewkroh approved these changes Dec 14, 2018
View reviewed changes
Copy link
Member

@andrewkroh andrewkroh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jsoriano
Copy link
Member Author

Merging this, darwin tests are pending on jenkins but queue is huge and it shouldn't affect Mac OS X.

@jsoriano jsoriano merged commit 4a3838c into elastic:master Dec 14, 2018
@jsoriano jsoriano deleted the systemd-unit-env-vars branch December 14, 2018 22:40
@jsoriano jsoriano mentioned this pull request Dec 19, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewkroh andrewkroh andrewkroh approved these changes

@tsg tsg tsg approved these changes

Assignees

@jsoriano jsoriano

Labels
bug :Packaging
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jsoriano @graphaelli @tsg @andrewkroh