Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add geo.name as the field for ad hoc location names. #248

Merged
merged 3 commits into from
Dec 7, 2018

Conversation

webmat
Copy link
Contributor

@webmat webmat commented Dec 6, 2018

This is useful for representing location manually, in some situations.

This idea originated in elastic/beats#9392

@webmat webmat self-assigned this Dec 6, 2018
@webmat
Copy link
Contributor Author

webmat commented Dec 6, 2018

Tentatively tagging for beta 2. I love this concept!

Copy link
Contributor

@ruflin ruflin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andrewvc The field is happening :-)

CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Contributor

@MikePaquette MikePaquette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice addition. LGTM.

Mathieu Martin added 3 commits December 7, 2018 11:02
This is useful for representing location manually, in some situations.
@webmat webmat merged commit f1f7aa6 into elastic:master Dec 7, 2018
@webmat webmat deleted the geo-name branch December 7, 2018 16:52
@andrewvc
Copy link

andrewvc commented Dec 7, 2018

What, this is awesome! Much appreciated @webmat !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants