Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add geo.name as the field for ad hoc location names. #248

Merged
merged 3 commits into from
Dec 7, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ All notable changes to this project will be documented in this file based on the
* Add `event.kind` and `event.outcome`. #242
* Add `client` and `server` objects and fields. #236
* Reintroduce a streamlined `user_agent` field set. #240
* Add `geo.name` for ad hoc location names. #248

### Improvements
* Improved the definition of the file fields #196
Expand Down
1 change: 1 addition & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -258,6 +258,7 @@ Note also that the `geo` fields are not expected to be used directly at the top
| <a name="geo.city_name"></a>geo.city_name | City name. | core | keyword | `Montreal` |
| <a name="geo.country_iso_code"></a>geo.country_iso_code | Country ISO code. | core | keyword | `CA` |
| <a name="geo.region_iso_code"></a>geo.region_iso_code | Region ISO code. | core | keyword | `CA-QC` |
| <a name="geo.name"></a>geo.name | User-defined description of a location, at the level of granularity they care about.<br/>Could be the name of their data centers, the floor number, if this describes a local physical entity, city names.<br/>Not typically used in automated geolocation. | extended | keyword | `boston-dc` |


## <a name="group"></a> Group fields
Expand Down
12 changes: 12 additions & 0 deletions fields.yml
Original file line number Diff line number Diff line change
Expand Up @@ -720,6 +720,18 @@
Region ISO code.
example: CA-QC

- name: name
level: extended
type: keyword
description: >
User-defined description of a location, at the level of granularity they care about.

Could be the name of their data centers, the floor number, if this describes
a local physical entity, city names.

Not typically used in automated geolocation.
example: boston-dc

- name: group
title: Group
group: 2
Expand Down
1 change: 1 addition & 0 deletions schema.csv
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,7 @@ geo.continent_name,keyword,core,North America
geo.country_iso_code,keyword,core,CA
geo.country_name,keyword,core,Canada
geo.location,geo_point,core,"{ ""lon"": -73.614830, ""lat"": 45.505918 }"
geo.name,keyword,extended,boston-dc
geo.region_iso_code,keyword,core,CA-QC
geo.region_name,keyword,core,Quebec
group.id,keyword,extended,
Expand Down
12 changes: 12 additions & 0 deletions schemas/geo.yml
Original file line number Diff line number Diff line change
Expand Up @@ -65,3 +65,15 @@
description: >
Region ISO code.
example: CA-QC

- name: name
level: extended
type: keyword
description: >
User-defined description of a location, at the level of granularity they care about.

Could be the name of their data centers, the floor number, if this describes
a local physical entity, city names.

Not typically used in automated geolocation.
example: boston-dc
4 changes: 4 additions & 0 deletions template.json
Original file line number Diff line number Diff line change
Expand Up @@ -339,6 +339,10 @@
"location": {
"type": "geo_point"
},
"name": {
"ignore_above": 1024,
"type": "keyword"
},
"region_iso_code": {
"ignore_above": 1024,
"type": "keyword"
Expand Down