Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: bump gopsutil to v4 #178

Merged
merged 2 commits into from
Aug 25, 2024
Merged

feat: bump gopsutil to v4 #178

merged 2 commits into from
Aug 25, 2024

Conversation

kruskall
Copy link
Member

@kruskall kruskall commented Aug 25, 2024 •
edited
Loading

What does this PR do?

bump gopsutil to the current major version
replace deprecated syscall.Syscall with syscall.SyscallN to fix linter issue

Why is it important?

v3 is no longer supported

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.md

Author's Checklist

  • [ ]

Related issues

@kruskall
feat: bump gopsutil to v4
1a40000 
v3 is no longer supported, bump to the current major version
@kruskall kruskall requested a review from a team as a code owner August 25, 2024 05:48
@kruskall kruskall requested review from rdner and VihasMakwana and removed request for a team August 25, 2024 05:48
@pierrehilbert pierrehilbert added the Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team label Aug 25, 2024
VihasMakwana
VihasMakwana approved these changes Aug 25, 2024
View reviewed changes
Copy link
Contributor

@VihasMakwana VihasMakwana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

nit: Can you also update PR description about migrating from syscall.Syscall to syscall.SyscallN?

@kruskall
Copy link
Member Author

Done! Thank you! 🙇

@kruskall kruskall merged commit 7b952e0 into elastic:main Aug 25, 2024
5 checks passed
@kruskall kruskall deleted the feat/gopsutil-v4 branch August 25, 2024 17:05
@VihasMakwana VihasMakwana mentioned this pull request Nov 11, 2024
Merged
This was referenced Nov 11, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VihasMakwana VihasMakwana VihasMakwana approved these changes

@rdner rdner Awaiting requested review from rdner rdner is a code owner automatically assigned from elastic/elastic-agent-data-plane

Assignees
No one assigned
Labels
Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kruskall @VihasMakwana @pierrehilbert