Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(xy): compute per series and global minPointsDistance #2571

Merged
merged 6 commits into from
Dec 10, 2024
Merged

fix(xy): compute per series and global minPointsDistance #2571

merged 6 commits into from
Dec 10, 2024

Conversation

markov00
Copy link
Member

@markov00 markov00 commented Dec 2, 2024

Summary

This PR improves the logic behind the auto visibility of points in Lines and Area charts.
Instead of using the bandwidth or the minInterval, it uses the actual minimum distance between points on each series.
If there are multiple series it uses the minimum of all the series to avoid having points on a line and not on the other.

Details

A storybook example was changed to introduce a different data cadence.

@markov00 markov00 added :styling Styling related issue :xy Bar/Line/Area chart related labels Dec 2, 2024
@markov00 markov00 changed the title Compute per series and global minPointsDistance fix(xy): compute per series and global minPointsDistance Dec 2, 2024
@markov00
Copy link
Member Author

markov00 commented Dec 4, 2024

buildkite update screenshots

@elastic-datavis
Copy link
Contributor

✅ Successful Deployment (build#4304) - e2caae9

@markov00 markov00 marked this pull request as ready for review December 5, 2024 09:09
@markov00 markov00 requested review from nickofthyme and a team December 5, 2024 09:09
nickofthyme
nickofthyme approved these changes Dec 10, 2024
View reviewed changes
Copy link
Collaborator

@nickofthyme nickofthyme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look to be a good improvement. Hopefully we are done with changing the iso point behavior for a while 😅.

@markov00 markov00 merged commit 8dae2c1 into elastic:main Dec 10, 2024
14 checks passed
@markov00 markov00 deleted the 2024_12_02-fix_line_point_visibility branch December 10, 2024 09:16
nickofthyme pushed a commit that referenced this pull request Dec 11, 2024
@semantic-release-bot
chore(release): 68.0.4 [skip ci]
9f0370b 
## [68.0.4](v68.0.3...v68.0.4) (2024-12-11)

### Bug Fixes

* **xy:** compute per series and global minPointsDistance ([#2571](#2571)) ([8dae2c1](8dae2c1))

### Performance Improvements

* fix unnecessary re-render ([#2573](#2573)) ([feacfd6](feacfd6))
@nickofthyme nickofthyme mentioned this pull request Jan 9, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickofthyme nickofthyme nickofthyme approved these changes

Assignees
No one assigned
Labels
:styling Styling related issue :xy Bar/Line/Area chart related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@markov00 @nickofthyme